Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: PRESUBMIT.py

Issue 9288045: PRESUBMIT check for JavaScript style errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes from Dan Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/PRESUBMIT.py » ('j') | chrome/browser/resources/PRESUBMIT.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index aa79141a90fa5217e6f29f1b7646c0744a21ffd5..c62357252280aace52744ce8d4ffa7c33632e181 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -8,10 +8,6 @@ See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
for more details about the presubmit API built into gcl.
"""
M-A Ruel 2012/02/08 14:30:39 Let's remove changes to this file from this CL. I'
Tyler Breisacher (Chromium) 2012/02/08 18:43:41 Done.
-
-import re
-
-
_EXCLUDED_PATHS = (
r"^breakpad[\\\/].*",
r"^native_client_sdk[\\\/].*",
@@ -30,7 +26,6 @@ _TEST_ONLY_WARNING = (
'Email joi@chromium.org if you have questions.')
-
def _CheckNoInterfacesInBase(input_api, output_api):
"""Checks to make sure no files in libbase.a have |@interface|."""
pattern = input_api.re.compile(r'^\s*@interface', input_api.re.MULTILINE)
@@ -340,6 +335,7 @@ def GetPreferredTrySlaves(project, change):
return ['mac_rel']
preferred = ['win_rel', 'linux_rel', 'mac_rel']
aura_re = '_aura[^/]*[.][^/]*'
- if any(re.search(aura_re, f.LocalPath()) for f in change.AffectedFiles()):
+ if any(input_api.re.search(aura_re, f.LocalPath())
+ for f in change.AffectedFiles()):
preferred.append('linux_chromeos')
return preferred
« no previous file with comments | « no previous file | chrome/browser/resources/PRESUBMIT.py » ('j') | chrome/browser/resources/PRESUBMIT.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698