Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: Source/WebCore/bindings/dart/custom/DartArrayBufferViewCustom.h

Issue 9288026: Switch to using dartdomgenerator.py for Dart interface and implementation generation. (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: Address comments Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebCore/bindings/dart/custom/DartArrayBufferViewCustom.h
diff --git a/Source/WebCore/bindings/dart/custom/DartArrayBufferViewCustom.h b/Source/WebCore/bindings/dart/custom/DartArrayBufferViewCustom.h
index bcd4dec3f3f372b6f748f80691e5a5827cedf78d..3cb0f2ec30cf39cabefbc541c828581390004424 100644
--- a/Source/WebCore/bindings/dart/custom/DartArrayBufferViewCustom.h
+++ b/Source/WebCore/bindings/dart/custom/DartArrayBufferViewCustom.h
@@ -41,12 +41,12 @@ namespace WebCore {
namespace DartArrayBufferViewInternal {
template<class ArrayClass, class ElementType>
-void constructWebGLArray(Dart_NativeArguments args)
+void createWebGLArray(Dart_NativeArguments args)
{
DartApiScope dartApiScope;
Dart_Handle exception;
{
- Dart_Handle arg1 = Dart_GetNativeArgument(args, 1);
+ Dart_Handle arg1 = Dart_GetNativeArgument(args, 0);
RefPtr<ArrayClass> array;
if (Dart_IsNumber(arg1)) {
ParameterAdapter<int> length(arg1);
@@ -87,7 +87,10 @@ void constructWebGLArray(Dart_NativeArguments args)
array = ArrayClass::create(bufferPtr, start, length);
}
}
- DartDOMWrapper::bindDOMObjectToDartWrapper(array.get(), Dart_GetNativeArgument(args, 0));
+
+ Dart_Handle result = toDartValue(array.get());
+ if (result)
+ Dart_SetReturnValue(args, result);
return;
}

Powered by Google App Engine
This is Rietveld 408576698