Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Side by Side Diff: chrome/browser/resources/task_manager/main.js

Issue 9288017: WebUI TaskManager: Use the specified height of row on refleshing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** @constructor */ 5 /** @constructor */
6 function TaskManager() { } 6 function TaskManager() { }
7 7
8 cr.addSingletonGetter(TaskManager); 8 cr.addSingletonGetter(TaskManager);
9 9
10 /** 10 /**
(...skipping 480 matching lines...) Expand 10 before | Expand all | Expand 10 after
491 cell.className = 'table-row-cell'; 491 cell.className = 'table-row-cell';
492 cell.id = 'column-' + pid + '-' + cm.getId(i); 492 cell.id = 'column-' + pid + '-' + cm.getId(i);
493 cell.appendChild( 493 cell.appendChild(
494 cm.getRenderFunction(i).call(null, data, cm.getId(i), table)); 494 cm.getRenderFunction(i).call(null, data, cm.getId(i), table));
495 495
496 listItem.appendChild(cell); 496 listItem.appendChild(cell);
497 497
498 // Stores the cell element to the dictionary. 498 // Stores the cell element to the dictionary.
499 this.elementsCache_[pid].cell[i] = cell; 499 this.elementsCache_[pid].cell[i] = cell;
500 } 500 }
501 listItem.style.height = (data['uniqueId'].length * 20) + 'px';
mazda 2012/01/26 09:37:16 What is this change intended for?
yoshiki 2012/01/26 10:10:45 I added an additional information as comment. Is i
501 listItem.data = data; 502 listItem.data = data;
502 503
503 // Stores the list item element, the number of columns and the number of 504 // Stores the list item element, the number of columns and the number of
504 // childlen. 505 // childlen.
505 this.elementsCache_[pid].listItem = listItem; 506 this.elementsCache_[pid].listItem = listItem;
506 this.elementsCache_[pid].cachedColumnSize = cm.size; 507 this.elementsCache_[pid].cachedColumnSize = cm.size;
507 this.elementsCache_[pid].cachedChildSize = data['uniqueId'].length; 508 this.elementsCache_[pid].cachedChildSize = data['uniqueId'].length;
508 509
509 return listItem; 510 return listItem;
510 }, 511 },
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
797 return; 798 return;
798 taskmanager.onTaskChange(start, length, tasks); 799 taskmanager.onTaskChange(start, length, tasks);
799 } 800 }
800 801
801 function taskRemoved(start, length) { 802 function taskRemoved(start, length) {
802 // Sometimes this can get called too early. 803 // Sometimes this can get called too early.
803 if (!taskmanager) 804 if (!taskmanager)
804 return; 805 return;
805 taskmanager.onTaskRemove(start, length); 806 taskmanager.onTaskRemove(start, length);
806 } 807 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698