Issue 9288011: Include what you use for allocation, api, assembler, and ast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9288011: Include what you use for allocation, api, assembler, and ast. (Closed)

Created:
8 years, 11 months ago by Kevin Millikin (Chromium)

Modified:
8 years, 11 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Include what you use for allocation, api, assembler, and ast. R=fschneider@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10505

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+116 lines, -67 lines)			Patch
M	src/allocation.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/allocation.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	src/api.h	View	2 chunks	+7 lines, -3 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+10 lines, -8 lines	0 comments	Download
M	src/arm/assembler-arm-inl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/assembler.h	View	1 chunk	+9 lines, -1 line	0 comments	Download
M	src/assembler.cc	View	1 chunk	+29 lines, -12 lines	0 comments	Download
M	src/ast.h	View	5 chunks	+31 lines, -10 lines	0 comments	Download
M	src/ast.cc	View	2 chunks	+8 lines, -3 lines	0 comments	Download
M	src/ia32/assembler-ia32-inl.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/jsregexp.h	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	src/mips/assembler-mips-inl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/type-info.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/v8globals.h	View	5 chunks	+1 line, -18 lines	0 comments	Download
M	src/x64/assembler-x64-inl.h	View	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

8 years, 11 months ago (2012-01-25 08:23:15 UTC) #3

On 2012/01/25 02:22:05, fschneider wrote:
> LGTM if it compiles.

I assume you are going to fix all source files... Would it be possible to hook
up this tool to check includes into presubmit in some way?

Expand Messages | Collapse Messages