src/hydrogen.cc - Issue 9286002: Eliminate overflow check after integer add and sub if result is truncated to int32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 9286002: Eliminate overflow check after integer add and sub if result is truncated to int32. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Eliminate overflow check after integer add and sub if result is truncated to int32. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen.cc

===================================================================

--- src/hydrogen.cc (revision 10863)

+++ src/hydrogen.cc (working copy)

@@ -2067,13 +2067,9 @@

for (int i = 0; i < phi_list()->length(); i++) {

HPhi* phi = phi_list()->at(i);

if (!phi->CheckFlag(HValue::kTruncatingToInt32)) continue;

- for (HUseIterator it(phi->uses()); !it.Done(); it.Advance()) {

- HValue* use = it.value();

- if (!use->CheckFlag(HValue::kTruncatingToInt32)) {

- phi->ClearFlag(HValue::kTruncatingToInt32);

- change = true;

- break;

- }

+ if (!phi->CheckUsesForFlag(HValue::kTruncatingToInt32)) {

+ phi->ClearFlag(HValue::kTruncatingToInt32);

+ change = true;

}

« no previous file with comments | « no previous file | src/hydrogen-instructions.h » ('j') | no next file with comments »