Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 9285007: Merge 105386 - REGRESSION(r100111): A 'change' event does not fire when a mouse drag (Closed)

Created:
8 years, 11 months ago by tkent
Modified:
8 years, 11 months ago
Reviewers:
tkent
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/963/
Visibility:
Public.

Description

Merge 105386 - REGRESSION(r100111): A 'change' event does not fire when a mouse drag occurs to switch elements in a listbox <select> https://bugs.webkit.org/show_bug.cgi?id=76244 Reviewed by Hajime Morita. Source/WebCore: Test: fast/forms/select/listbox-drag-in-non-multiple.html * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::updateSelectedState): Do not update m_activeSelectionState for non-multiple <select>. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Use setActiveSelection*Index() and updateListBoxSelection(true) instead of updateSelectedState() because updateSelectedState() updates m_lastOnChangeSelection and will prevent the mouseup handler from dispatching 'change' event. We should not call listBoxOnChange() in the mousemove handler in order to align the behavior of IE and Firefox. LayoutTests: * fast/forms/resources/common.js: (mouseMoveToIndexInListbox): Added. * fast/forms/select/listbox-drag-in-non-multiple-expected.txt: Added. * fast/forms/select/listbox-drag-in-non-multiple.html: Added. TBR=tkent@chromium.org BUG=crbug.com/110068 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=105692

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M LayoutTests/fast/forms/resources/common.js View 1 chunk +9 lines, -0 lines 0 comments Download
A + LayoutTests/fast/forms/select/listbox-drag-in-non-multiple.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/select/listbox-drag-in-non-multiple-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/html/HTMLSelectElement.cpp View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tkent
8 years, 11 months ago (2012-01-24 05:19:15 UTC) #1
tkent
8 years, 11 months ago (2012-01-24 05:21:49 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698