cleanup from r3556

frog/value.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
 interface CallingContext {
   MemberSet findMembers(String name);
   CounterLog get counters();
   Library get library();
   bool get isStatic();
@@ skipping 57 matching lines @@
 
     var member = getMem(context, name, node);
     if (member != null) {
       member._set(context, node, this, value);
     }
     return new PureStaticValue(value.type, node.span);
   }
 
   Value setIndex(CallingContext context, Value index, Node node, Value value,
       [int kind=0, int returnKind=ReturnKind.IGNORE]) {
-    return invoke(context, ':setindex', node,
+    var tmp = invoke(context, ':setindex', node,
       new Arguments(null, [index, value]));
+    return new PureStaticValue(value.type, node.span);
   }
 
   Value unop(int kind, CallingContext context, var node) {
     switch (kind) {
       case TokenKind.NOT:
         // TODO(jimhug): Issue #359 seeks to clarify this behavior.
         // ?var newVal = convertTo(context, world.nonNullBool);
         return new PureStaticValue(world.boolType, node.span);
       case TokenKind.ADD:
         if (!isConst && !type.isNum) {
@@ skipping 712 matching lines @@
       if (!world.objectType.varStubs.containsKey(checkName)) {
         world.objectType.varStubs[checkName] =
           new VarMethodStub(checkName, null, Arguments.EMPTY, 'return false');
       }
     }
     return new Value(world.nonNullBool, testCode, span);
   }
 
   void convertWarning(Type toType) {
     // TODO(jmesserly): better error messages for type conversion failures
-    world.warning('type "${type.name}" is not assignable to "${toType.name}"',
+    world.warning(
+        'type "${type.fullname}" is not assignable to "${toType.fullname}"',
         span);
   }
 
   Value invokeNoSuchMethod(CallingContext context, String name, Node node,
       [Arguments args]) {
     if (isType) {
       world.error('member lookup failed for "$name"', node.span);
     }
 
     var pos = '';
@@ skipping 785 matching lines @@
     }
     return super.unop(kind, context, node);
   }
   Value binop(int kind, var other, CallingContext context, var node) {
     if (value != null) {
       return replaceValue(value.binop(kind, _unwrap(other), context, node));
     }
     return super.binop(kind, other, context, node);
   }
 }