Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 9284027: Issue 1317. Mark test as failing in release (Closed)

Created:
8 years, 11 months ago by scheglov
Modified:
8 years, 11 months ago
Reviewers:
mmendez, zundel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tests/co19/co19-compiler.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
8 years, 11 months ago (2012-01-24 16:05:01 UTC) #1
zundel
LGTM. To investigate, I added a 'print()' line after the call to 'string'.contains() and it ...
8 years, 11 months ago (2012-01-24 16:30:36 UTC) #2
mmendez
8 years, 11 months ago (2012-01-24 19:12:33 UTC) #3
FWIW, it might be worth it to look at the cllosure optimized code with the human
readable flag turned on, if that has not been done already.

On 2012/01/24 16:30:36, zundel wrote:
> LGTM.
> 
> To investigate, I added a 'print()' line after the call to 'string'.contains()
> and it printed out.
> 
> I've tried going through and understanding why this happens, and all I can
think
> of is that closure is doing some kind of optimization.  There is no explicit
> null check, so possibly closure, knowing that pattern is NULL inadvertently
> avoids the NULL pointer reference.

Powered by Google App Engine
This is Rietveld 408576698