Add policies for specific parts of device status reports.

Add policies for specific parts of device status reports.

BUG=chromium-os:24308
TEST=Manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119058

[Patrick Dubroy, 2012-01-24 16:01:22]

Hey Joao, can you please review?

[Joao da Silva, 2012-01-24 16:21:20]

Looks good, it's only missing the protobuf changes for the device policies. See
inline.

http://codereview.chromium.org/9284025/diff/1005/chrome/app/policy/policy_tem...
File chrome/app/policy/policy_templates.json (right):

http://codereview.chromium.org/9284025/diff/1005/chrome/app/policy/policy_tem...
chrome/app/policy/policy_templates.json:2277: 'device_only': True,
This means the protobuf generated for user policy will not include these
policies; they should instead be added manually to the device policy protobuf in
chrome/browser/policy/chrome_device_policy.proto. Then edit
DevicePolicyCache::DecodeDevicePolicy() and decode that protobuf field into the
corresponding policy value.

http://codereview.chromium.org/9284025/diff/1005/chrome/common/pref_names.h
File chrome/common/pref_names.h (right):

http://codereview.chromium.org/9284025/diff/1005/chrome/common/pref_names.h#n...
chrome/common/pref_names.h:618: extern const char kReportDeviceActivityTimes[];
These preferences aren't registered anywhere. If that isn't meant to be part of
this CL it's ok.

[Patrick Dubroy, 2012-01-24 17:03:42]

http://codereview.chromium.org/9284025/diff/1005/chrome/app/policy/policy_tem...
File chrome/app/policy/policy_templates.json (right):

http://codereview.chromium.org/9284025/diff/1005/chrome/app/policy/policy_tem...
chrome/app/policy/policy_templates.json:2277: 'device_only': True,
On 2012/01/24 16:21:20, Joao da Silva wrote:
> This means the protobuf generated for user policy will not include these
> policies; they should instead be added manually to the device policy protobuf
in
> chrome/browser/policy/chrome_device_policy.proto. Then edit
> DevicePolicyCache::DecodeDevicePolicy() and decode that protobuf field into
the
> corresponding policy value.

Done.

http://codereview.chromium.org/9284025/diff/1005/chrome/common/pref_names.h
File chrome/common/pref_names.h (right):

http://codereview.chromium.org/9284025/diff/1005/chrome/common/pref_names.h#n...
chrome/common/pref_names.h:618: extern const char kReportDeviceActivityTimes[];
On 2012/01/24 16:21:20, Joao da Silva wrote:
> These preferences aren't registered anywhere. If that isn't meant to be part
of
> this CL it's ok.

Yeah, I will submit a separate CL that registers & uses the prefs.

[Joao da Silva, 2012-01-24 17:09:25]

LGTM. Please run through linux_chromeos and linux_chromeos_clang before landing.