Operators.

frog/leg/ssa/builder.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Interceptors {
   Compiler compiler;
   Interceptors(Compiler this.compiler);
 
   SourceString mapOperatorToMethodName(Operator op) {
     String name = op.source.stringValue;
@@ skipping 218 matching lines @@
           value = new HLiteral(null, HType.UNKNOWN);
           add(value);
         }
         fieldValues.add(value);
       }
     }
     HForeignNew newObject = new HForeignNew(classElement, fieldValues);
     add(newObject);
 
     // Call the method body.
-    SourceString methodName = compiler.namer.getConstructorName(bodyElement);
+    SourceString methodName = bodyElement.name;
 
     List bodyCallInputs = <HInstruction>[];
     bodyCallInputs.add(newObject);
     for (Link link = parameters.nodes; !link.isEmpty(); link = link.tail) {
       Link<Node> nodeLink = link.head.definitions.nodes;
       // We expect exactly one identifier.
       assert(!nodeLink.isEmpty() && nodeLink.tail.isEmpty());
       Node current = nodeLink.head;
       Element parameterElement = elements[current];
       HInstruction currentValue = definitions[parameterElement];
@@ skipping 646 matching lines @@
   addVisitedSendArgumentsToList(Link<Node> link, List<HInstruction> list) {
     for (; !link.isEmpty(); link = link.tail) {
       visit(link.head);
       list.add(pop());
     }
   }
 
   visitDynamicSend(Send node) {
     var inputs = <HInstruction>[];
 
-    SourceString dartMethodName = node.selector.asIdentifier().source;
+    SourceString dartMethodName;
+    bool isNotEquals = false;
+    if (node.isIndex && !node.arguments.tail.isEmpty()) {
+      dartMethodName = Elements.constructOperatorName(
+          const SourceString('operator'),
+          const SourceString('[]='));
+    } else if (node.selector.asOperator() != null) {
+      SourceString name = node.selector.asIdentifier().source;
+      isNotEquals = name.stringValue === '!=';
+      dartMethodName = Elements.constructOperatorName(
+          const SourceString('operator'),
+          name,
+          node.argumentsNode is Prefix);
+    } else {
+      dartMethodName = node.selector.asIdentifier().source;
+    }
 
     Element interceptor = null;
     if (methodInterceptionEnabled) {
       interceptor = interceptors.getStaticInterceptor(dartMethodName,
                                                       node.argumentCount());
     }
     if (interceptor != null) {
       HStatic target = new HStatic(interceptor);
       add(target);
       inputs.add(target);
@@ skipping 12 matching lines @@
       inputs.add(receiver);
     } else {
       visit(node.receiver);
       inputs.add(pop());
     }
 
     addVisitedSendArgumentsToList(node.arguments, inputs);
 
     // The first entry in the inputs list is the receiver.
     push(new HInvokeDynamicMethod(dartMethodName, inputs));
+
+    if (isNotEquals) {
+      HNot not = new HNot(popBoolified());
+      push(not);
+    }
   }
 
   visitClosureSend(Send node) {
     assert(node.receiver === null);
     Element element = elements[node];
     HInstruction closureTarget;
     if (element === null) {
       visit(node.selector);
       closureTarget = pop();
     } else {
@@ skipping 59 matching lines @@
     Element element = elements[node];
     HStatic target = new HStatic(element);
     add(target);
     var inputs = <HInstruction>[];
     inputs.add(target);
     addVisitedSendArgumentsToList(node.arguments, inputs);
     push(new HInvokeStatic(inputs));
   }
 
   visitSend(Send node) {
-    if (node.selector is Operator) {
+    if (node.selector is Operator && methodInterceptionEnabled) {
       visitOperatorSend(node);
     } else if (node.isPropertyAccess) {
       generateGetter(node, elements[node]);
     } else if (Elements.isClosureSend(node, elements)) {
       visitClosureSend(node);
     } else if (node.isSuperCall) {
       visitSuperSend(node);
     } else {
       Element element = elements[node];
       if (element === null) {
@@ skipping 23 matching lines @@
     if (element is !VariableElement) {
       compiler.internalError("expected a variable", node: node);
     }
     definitions[element] = value;
     return value;
   }
 
   visitSendSet(SendSet node) {
     Operator op = node.assignmentOperator;
     if (node.isIndex) {
-      HStatic target = new HStatic(interceptors.getIndexAssignmentInterceptor());
-      add(target);
-      visit(node.receiver);
-      HInstruction receiver = pop();
-      visit(node.argumentsNode);
-      if (const SourceString("=") == op.source) {
-        HInstruction value = pop();
-        HInstruction index = pop();
-        push(new HIndexAssign(target, receiver, index, value));
+      if (!methodInterceptionEnabled) {
+        assert(op.source == const SourceString("="));

[Lasse Reichstein Nielsen, 2012/01/27 09:42:34]

Might as well do 
  op.source.stringValue == "="
(or even ===).

[ngeoffray, 2012/01/27 10:50:04]

Done.

+        visitDynamicSend(node);
       } else {
-        HInstruction value;
-        HInstruction index;
-        bool isCompoundAssignment = op.source.stringValue.endsWith('=');
-        bool isPrefix = !node.isPostfix;  // Compound assignments are prefix.
-        Element getter = elements[node.selector];
-        if (isCompoundAssignment) {
-          value = pop();
-          index = pop();
+        HStatic target = new HStatic(
+            interceptors.getIndexAssignmentInterceptor());
+        add(target);
+        visit(node.receiver);
+        HInstruction receiver = pop();
+        visit(node.argumentsNode);
+        if (const SourceString("=") == op.source) {
+          HInstruction value = pop();
+          HInstruction index = pop();
+          push(new HIndexAssign(target, receiver, index, value));
         } else {
-          index = pop();
-          value = new HLiteral(1, HType.INTEGER);
-          add(value);
-        }
-        HStatic indexMethod = new HStatic(interceptors.getIndexInterceptor());
-        add(indexMethod);
-        HInstruction left = new HIndex(indexMethod, receiver, index);
-        add(left);
-        Element opElement = elements[op];
-        visitBinary(left, op, value);
-        HInstruction assign = new HIndexAssign(target, receiver, index, pop());
-        add(assign);
-        if (isPrefix) {
-          stack.add(assign);
-        } else {
-          stack.add(left);
+          HInstruction value;
+          HInstruction index;
+          bool isCompoundAssignment = op.source.stringValue.endsWith('=');
+          bool isPrefix = !node.isPostfix;  // Compound assignments are prefix.

[Lasse Reichstein Nielsen, 2012/01/27 09:42:34]

"are prefix." => "are considered as being prefix."
They *are* infix.

[ngeoffray, 2012/01/27 10:50:04]

Done.

+          Element getter = elements[node.selector];
+          if (isCompoundAssignment) {
+            value = pop();
+            index = pop();
+          } else {
+            index = pop();
+            value = new HLiteral(1, HType.INTEGER);
+            add(value);
+          }
+          HStatic indexMethod = new HStatic(interceptors.getIndexInterceptor());
+          add(indexMethod);
+          HInstruction left = new HIndex(indexMethod, receiver, index);
+          add(left);
+          Element opElement = elements[op];
+          visitBinary(left, op, value);
+          HInstruction assign = new HIndexAssign(
+              target, receiver, index, pop());
+          add(assign);
+          if (isPrefix) {
+            stack.add(assign);
+          } else {
+            stack.add(left);
+          }
         }
       }
-    } else if (const SourceString("=") == op.source) {
+    } else if (const SourceString("=") == op.source && !node.isIndex) {

[Lasse Reichstein Nielsen, 2012/01/27 09:42:34]

Change that to
 assert(!node.isIndex);
It can't happen with this being an else branch of an if with condition
(node.isIndex).

[ngeoffray, 2012/01/27 10:50:04]

You're right, that's a leftover from a previous implementation. Removed (and I
did not add an assert since the first if (node.isIndex) is quite trivial to
read).

       Element element = elements[node];
       Link<Node> link = node.arguments;
       assert(!link.isEmpty() && link.tail.isEmpty());
       visit(link.head);
       HInstruction value = pop();
       generateSetter(node, element, value);
     } else if (op.source.stringValue === "is") {
       compiler.internalError("is-operator as SendSet", node: op);
     } else {
       assert(const SourceString("++") == op.source ||
@@ skipping 296 matching lines @@
   }
 
   visitCatchBlock(CatchBlock node) {
     compiler.unimplemented('SsaBuilder.visitCatchBlock', node: node);
   }
 
   visitTypedef(Typedef node) {
     compiler.unimplemented('SsaBuilder.visitTypedef', node: node);
   }
 }