Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: Source/WebCore/loader/SubresourceLoader.cpp

Issue 9283038: Merge 105226 - Ensure we don't cancel revalidation of a CachedResource (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/963/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebCore/loader/SubresourceLoader.h ('k') | Source/WebCore/loader/cache/CachedResource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/loader/SubresourceLoader.cpp
===================================================================
--- Source/WebCore/loader/SubresourceLoader.cpp (revision 105796)
+++ Source/WebCore/loader/SubresourceLoader.cpp (working copy)
@@ -156,12 +156,9 @@
if (response.httpStatusCode() == 304) {
// 304 Not modified / Use local copy
// Existing resource is ok, just use it updating the expiration time.
- m_state = Revalidating;
memoryCache()->revalidationSucceeded(m_resource, response);
- if (!reachedTerminalState()) {
+ if (!reachedTerminalState())
ResourceLoader::didReceiveResponse(response);
- didFinishLoading(monotonicallyIncreasingTime());
- }
return;
}
// Did not get 304 response, continue as a regular resource load.
@@ -244,7 +241,7 @@
void SubresourceLoader::didFinishLoading(double finishTime)
{
- if (m_state != Initialized && m_state != Revalidating)
+ if (m_state != Initialized)
return;
ASSERT(!reachedTerminalState());
ASSERT(!m_resource->resourceToRevalidate());
« no previous file with comments | « Source/WebCore/loader/SubresourceLoader.h ('k') | Source/WebCore/loader/cache/CachedResource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698