Implement field parameter for generative constructors.

frog/leg/ssa/builder.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Interceptors {
   Compiler compiler;
   Interceptors(Compiler this.compiler);
 
   SourceString mapOperatorToMethodName(Operator op) {
     String name = op.source.stringValue;
@@ skipping 221 matching lines @@
     }
     HForeignNew newObject = new HForeignNew(classElement, fieldValues);
     add(newObject);
 
     // Call the method body.
     SourceString methodName = compiler.namer.getConstructorName(bodyElement);
 
     List bodyCallInputs = <HInstruction>[];
     bodyCallInputs.add(newObject);
     for (Link link = parameters.nodes; !link.isEmpty(); link = link.tail) {
-      Link<Node> identifierLink = link.head.definitions.nodes;
+      Link<Node> nodeLink = link.head.definitions.nodes;
       // We expect exactly one identifier.
-      assert(!identifierLink.isEmpty() && identifierLink.tail.isEmpty());
-      if (identifierLink.head is !Identifier) {
-        compiler.unimplemented("SsaBuilder.buildFactory non-identifier");
-      }
-      Identifier name = identifierLink.head;
-      Element parameterElement = elements[name];
+      assert(!nodeLink.isEmpty() && nodeLink.tail.isEmpty());
+      Node current = nodeLink.head;
+      Element parameterElement = elements[current];
       HInstruction currentValue = definitions[parameterElement];
       bodyCallInputs.add(currentValue);
     }
     add(new HInvokeDynamicMethod(methodName, bodyCallInputs));
     close(new HReturn(newObject)).addSuccessor(graph.exit);
     return closeFunction();
   }
 
   void openFunction(FunctionElement functionElement) {
     stack = new List<HInstruction>();
     definitions = new Map<Element, HInstruction>();
 
     graph = new HGraph();
     HBasicBlock block = graph.addNewBlock();
 
     open(graph.entry);
     if (functionElement.isInstanceMember()) {
       thisDefinition = new HThis();
       add(thisDefinition);
     }
     FunctionExpression function = functionElement.parseNode(compiler, compiler);
-    visitParameterValues(function.parameters);
+    handleParameterValues(function.parameters);
     close(new HGoto()).addSuccessor(block);
 
     open(block);
   }
 
   HGraph closeFunction() {
     // TODO(kasperl): Make this goto an implicit return.
     if (!isAborted()) close(new HGoto()).addSuccessor(graph.exit);
     graph.finalize();
     return graph;
@@ skipping 43 matching lines @@
   HBoolify popBoolified() {
     HBoolify boolified = new HBoolify(pop());
     add(boolified);
     return boolified;
   }
 
   void visit(Node node) {
     if (node !== null) node.accept(this);
   }
 
-  visitParameterValues(NodeList parameters) {
+  handleParameterValues(NodeList parameters) {
     int parameterIndex = 0;
     for (Link<Node> link = parameters.nodes;
          !link.isEmpty();
          link = link.tail) {
       VariableDefinitions container = link.head;
-      Link<Node> identifierLink = container.definitions.nodes;
+      Link<Node> nodeLink = container.definitions.nodes;
       // The identifier link must contain exactly one argument.
-      assert(!identifierLink.isEmpty() && identifierLink.tail.isEmpty());
-      if (identifierLink.head is !Identifier) {
-        compiler.unimplemented(
-            "SsaBuilder.visitParameterValues non-identifier", node: parameters);
-      }
-      Identifier parameterId = identifierLink.head;
-      VariableElement element = elements[parameterId];
+      assert(!nodeLink.isEmpty() && nodeLink.tail.isEmpty());
+      Node current = nodeLink.head;
+      VariableElement element = elements[current];
       HParameterValue parameter = new HParameterValue(element);
       add(parameter);
       definitions[element] = parameter;
     }
   }
 
   visitBlock(Block node) {
     for (Link<Node> link = node.statements.nodes;
          !link.isEmpty();
          link = link.tail) {
@@ skipping 1050 matching lines @@
   }
 
   visitCatchBlock(CatchBlock node) {
     compiler.unimplemented('SsaBuilder.visitCatchBlock', node: node);
   }
 
   visitTypedef(Typedef node) {
     compiler.unimplemented('SsaBuilder.visitTypedef', node: node);
   }
 }