Monitoring proxy for time series data

appengine/chrome_infra_mon_proxy/admin_handler.py

Index: appengine/chrome_infra_mon_proxy/admin_handler.py
diff --git a/appengine/chrome_infra_mon_proxy/admin_handler.py b/appengine/chrome_infra_mon_proxy/admin_handler.py
new file mode 100644
index 0000000000000000000000000000000000000000..b34f0460de2134d58c11bd0853cde2e5a66b5a85
--- /dev/null
+++ b/appengine/chrome_infra_mon_proxy/admin_handler.py
@@ -0,0 +1,139 @@
+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import json
+import logging
+import os
+import sys
+import webapp2
+
+from google.appengine.api import users
+from webapp2_extras import jinja2
+
+import common
+
+class AdminCommand(object):
+  """Base class for administrative commands.
+
+  Implement get() and post() methods in the subclasses.
+  """
+
+  def __init__(self, handler):
+    self._handler = handler
+
+  @property
+  def request(self):
+    return self._handler.request
+
+  @property
+  def response(self):
+    return self._handler.response
+
+  def render_response(self, _template, **context):
+    self._handler.render_response(_template, **context)
+
+
+class AdminPage(AdminCommand):
+  """Display the admin page."""
+
+  def get(self):
+    context = {'title': 'Admin: Chrome Infra Monitoring Proxy'}
+    self.render_response('admin.html', **context)
+
+  def post(self):
+    self.response.set_status(403)
+    return
+
+
+class SetCredentials(AdminCommand):
+  """Save new credentials for the Monacq endpoint."""
+
+  @staticmethod
+  def setParams(params, data):
+    """Serialize data fields into template parameters."""
+    params['url'] = data.url
+    params['credentials'] = json.dumps(data.credentials)
+    params['scopes'] = '\n'.join(data.scopes)
+    params['headers'] = json.dumps(data.headers)
+
+  # Deserialize form fields. It is an inverse of setParams().
+  _parsers = {
+      'url': lambda v: v,
+      'credentials': json.loads,
+      'scopes': lambda v: [l.strip() for l in v.splitlines() if l],
+      'headers': json.loads,
+  }
+
+  def get(self):
+    params = {
+        'message': '',
+        'title': 'Config: Chrome Infra Monitoring Proxy',
+    }
+    data = common.MonAcqData.get_by_id(common.CONFIG_DATA_KEY)
+    if data:
+      self.setParams(params, data)
+    self.render_response('set_credentials.html', **params)
+
+  def post(self):
+    params = {
+        'message': '',
+        'title': 'Config: Chrome Infra Monitoring Proxy',
+    }
+    data = common.MonAcqData.get_or_insert(common.CONFIG_DATA_KEY)
+    self.setParams(params, data)
+
+    updated_fields = False
+    failed_fields = []
+    for field, parser in self._parsers.iteritems():
+      if not self.request.get(field):
+        continue
+      try:
+        setattr(data, field, parser(self.request.get(field)))
+        updated_fields = True
+      except ValueError:
+        failed_fields.append(field)
+      params[field] = self.request.get(field)
+
+    if failed_fields:
+      params['message'] = 'Failed to update %s. Please try again.' % (
+          ', '.join(failed_fields))
+    elif updated_fields:
+      data.put()
+      self.setParams(params, data)
+      params['message'] = 'Updated configuration.'
+      logging.info('Updated configuration: %r', data)
+    self.render_response('set_credentials.html', **params)
+
+
+commands = {
+  '': AdminPage,
+  'set-credentials': SetCredentials,
+}
+
+
+# TODO(sergeyberezin): reimplement this using auth groups.
+class AdminDispatch(common.BaseHandler):
+  """Provide a cached Jinja environment to each request."""
+
+  def get(self, command):
+    if not users.get_current_user():
+      self.redirect(users.create_login_url(self.request.url))
+      return
+    if not users.is_current_user_admin():
+      self.response.set_status(403)
+      return
+    commands[command](self).get()
+
+  def post(self, command):

[Vadim Sh., 2015/04/28 18:10:43]

All POSTs here need XSRF protection, otherwise following scenario is possible
0) You are logged in the site (e.g. visited it earlier today).
1) Someone sends you a link "Look, pictures of cute kittens". Or more
realistically, post to chrome-troopers "OMG, everything is broken" with
URLshortened link.
2) You open the link, observe the kittens.
3) Meanwhile invisible POST form on the page posts to /admin/set-credentials
abusing cookies your browser has. Boom, everything is broken.

If you use auth.AuthenticationHandler, adding XSRF protection is rather trivia
(just put xsrf_token hidden field in the form, e.g
https://github.com/luci/luci-py/blob/master/appengine/swarming/handlers_front...)

[Sergey Berezin, 2015/04/28 19:35:27]

Awesome! Thanks, Vadim, you just answered my not-yet-asked question on how to
finish my TODO above. I'll do that in the very next CL.

+    if not users.is_current_user_admin():
+      self.response.set_status(403)
+      return
+    commands[command](self).post()
+
+
+admin_handlers = [
+    (r'/admin/(.*)', AdminDispatch),
+]
+
+admin = webapp2.WSGIApplication(admin_handlers, debug=True)