Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: src/x64/stub-cache-x64.cc

Issue 9280007: Replaced LookupResult::IsProperty by LookupResult::IsFound where possible. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: 2 fixes Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1027 matching lines...) Expand 10 before | Expand all | Expand 10 after
1038 ASSERT(interceptor_holder->HasNamedInterceptor()); 1038 ASSERT(interceptor_holder->HasNamedInterceptor());
1039 ASSERT(!interceptor_holder->GetNamedInterceptor()->getter()->IsUndefined()); 1039 ASSERT(!interceptor_holder->GetNamedInterceptor()->getter()->IsUndefined());
1040 1040
1041 // Check that the receiver isn't a smi. 1041 // Check that the receiver isn't a smi.
1042 __ JumpIfSmi(receiver, miss); 1042 __ JumpIfSmi(receiver, miss);
1043 1043
1044 // So far the most popular follow ups for interceptor loads are FIELD 1044 // So far the most popular follow ups for interceptor loads are FIELD
1045 // and CALLBACKS, so inline only them, other cases may be added 1045 // and CALLBACKS, so inline only them, other cases may be added
1046 // later. 1046 // later.
1047 bool compile_followup_inline = false; 1047 bool compile_followup_inline = false;
1048 if (lookup->IsProperty() && lookup->IsCacheable()) { 1048 if (lookup->IsFound() && lookup->IsCacheable()) {
1049 if (lookup->type() == FIELD) { 1049 if (lookup->type() == FIELD) {
1050 compile_followup_inline = true; 1050 compile_followup_inline = true;
1051 } else if (lookup->type() == CALLBACKS && 1051 } else if (lookup->type() == CALLBACKS &&
1052 lookup->GetCallbackObject()->IsAccessorInfo()) { 1052 lookup->GetCallbackObject()->IsAccessorInfo()) {
1053 compile_followup_inline = 1053 compile_followup_inline =
1054 AccessorInfo::cast(lookup->GetCallbackObject())->getter() != NULL; 1054 AccessorInfo::cast(lookup->GetCallbackObject())->getter() != NULL;
1055 } 1055 }
1056 } 1056 }
1057 1057
1058 if (compile_followup_inline) { 1058 if (compile_followup_inline) {
(...skipping 2527 matching lines...) Expand 10 before | Expand all | Expand 10 after
3586 Handle<Code> ic_miss = masm->isolate()->builtins()->KeyedStoreIC_Miss(); 3586 Handle<Code> ic_miss = masm->isolate()->builtins()->KeyedStoreIC_Miss();
3587 __ jmp(ic_miss, RelocInfo::CODE_TARGET); 3587 __ jmp(ic_miss, RelocInfo::CODE_TARGET);
3588 } 3588 }
3589 3589
3590 3590
3591 #undef __ 3591 #undef __
3592 3592
3593 } } // namespace v8::internal 3593 } } // namespace v8::internal
3594 3594
3595 #endif // V8_TARGET_ARCH_X64 3595 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698