Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: src/ia32/stub-cache-ia32.cc

Issue 9280007: Replaced LookupResult::IsProperty by LookupResult::IsFound where possible. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: 2 fixes Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1035 matching lines...) Expand 10 before | Expand all | Expand 10 after
1046 ASSERT(interceptor_holder->HasNamedInterceptor()); 1046 ASSERT(interceptor_holder->HasNamedInterceptor());
1047 ASSERT(!interceptor_holder->GetNamedInterceptor()->getter()->IsUndefined()); 1047 ASSERT(!interceptor_holder->GetNamedInterceptor()->getter()->IsUndefined());
1048 1048
1049 // Check that the receiver isn't a smi. 1049 // Check that the receiver isn't a smi.
1050 __ JumpIfSmi(receiver, miss); 1050 __ JumpIfSmi(receiver, miss);
1051 1051
1052 // So far the most popular follow ups for interceptor loads are FIELD 1052 // So far the most popular follow ups for interceptor loads are FIELD
1053 // and CALLBACKS, so inline only them, other cases may be added 1053 // and CALLBACKS, so inline only them, other cases may be added
1054 // later. 1054 // later.
1055 bool compile_followup_inline = false; 1055 bool compile_followup_inline = false;
1056 if (lookup->IsProperty() && lookup->IsCacheable()) { 1056 if (lookup->IsFound() && lookup->IsCacheable()) {
1057 if (lookup->type() == FIELD) { 1057 if (lookup->type() == FIELD) {
1058 compile_followup_inline = true; 1058 compile_followup_inline = true;
1059 } else if (lookup->type() == CALLBACKS && 1059 } else if (lookup->type() == CALLBACKS &&
1060 lookup->GetCallbackObject()->IsAccessorInfo()) { 1060 lookup->GetCallbackObject()->IsAccessorInfo()) {
1061 compile_followup_inline = 1061 compile_followup_inline =
1062 AccessorInfo::cast(lookup->GetCallbackObject())->getter() != NULL; 1062 AccessorInfo::cast(lookup->GetCallbackObject())->getter() != NULL;
1063 } 1063 }
1064 } 1064 }
1065 1065
1066 if (compile_followup_inline) { 1066 if (compile_followup_inline) {
(...skipping 2748 matching lines...) Expand 10 before | Expand all | Expand 10 after
3815 Handle<Code> ic_miss = masm->isolate()->builtins()->KeyedStoreIC_Miss(); 3815 Handle<Code> ic_miss = masm->isolate()->builtins()->KeyedStoreIC_Miss();
3816 __ jmp(ic_miss, RelocInfo::CODE_TARGET); 3816 __ jmp(ic_miss, RelocInfo::CODE_TARGET);
3817 } 3817 }
3818 3818
3819 3819
3820 #undef __ 3820 #undef __
3821 3821
3822 } } // namespace v8::internal 3822 } } // namespace v8::internal
3823 3823
3824 #endif // V8_TARGET_ARCH_IA32 3824 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698