Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: src/bootstrapper.cc

Issue 9280007: Replaced LookupResult::IsProperty by LookupResult::IsFound where possible. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: 2 fixes Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ast.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1081 matching lines...) Expand 10 before | Expand all | Expand 10 after
1092 result, factory->length_symbol(), 1092 result, factory->length_symbol(),
1093 factory->undefined_value(), DONT_ENUM)); 1093 factory->undefined_value(), DONT_ENUM));
1094 CHECK_NOT_EMPTY_HANDLE(isolate, 1094 CHECK_NOT_EMPTY_HANDLE(isolate,
1095 JSObject::SetLocalPropertyIgnoreAttributes( 1095 JSObject::SetLocalPropertyIgnoreAttributes(
1096 result, factory->callee_symbol(), 1096 result, factory->callee_symbol(),
1097 factory->undefined_value(), DONT_ENUM)); 1097 factory->undefined_value(), DONT_ENUM));
1098 1098
1099 #ifdef DEBUG 1099 #ifdef DEBUG
1100 LookupResult lookup(isolate); 1100 LookupResult lookup(isolate);
1101 result->LocalLookup(heap->callee_symbol(), &lookup); 1101 result->LocalLookup(heap->callee_symbol(), &lookup);
1102 ASSERT(lookup.IsProperty() && (lookup.type() == FIELD)); 1102 ASSERT(lookup.IsFound() && (lookup.type() == FIELD));
1103 ASSERT(lookup.GetFieldIndex() == Heap::kArgumentsCalleeIndex); 1103 ASSERT(lookup.GetFieldIndex() == Heap::kArgumentsCalleeIndex);
1104 1104
1105 result->LocalLookup(heap->length_symbol(), &lookup); 1105 result->LocalLookup(heap->length_symbol(), &lookup);
1106 ASSERT(lookup.IsProperty() && (lookup.type() == FIELD)); 1106 ASSERT(lookup.IsFound() && (lookup.type() == FIELD));
1107 ASSERT(lookup.GetFieldIndex() == Heap::kArgumentsLengthIndex); 1107 ASSERT(lookup.GetFieldIndex() == Heap::kArgumentsLengthIndex);
1108 1108
1109 ASSERT(result->map()->inobject_properties() > Heap::kArgumentsCalleeIndex); 1109 ASSERT(result->map()->inobject_properties() > Heap::kArgumentsCalleeIndex);
1110 ASSERT(result->map()->inobject_properties() > Heap::kArgumentsLengthIndex); 1110 ASSERT(result->map()->inobject_properties() > Heap::kArgumentsLengthIndex);
1111 1111
1112 // Check the state of the object. 1112 // Check the state of the object.
1113 ASSERT(result->HasFastProperties()); 1113 ASSERT(result->HasFastProperties());
1114 ASSERT(result->HasFastElements()); 1114 ASSERT(result->HasFastElements());
1115 #endif 1115 #endif
1116 } 1116 }
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
1190 1190
1191 // Add length property only for strict mode boilerplate. 1191 // Add length property only for strict mode boilerplate.
1192 CHECK_NOT_EMPTY_HANDLE(isolate, 1192 CHECK_NOT_EMPTY_HANDLE(isolate,
1193 JSObject::SetLocalPropertyIgnoreAttributes( 1193 JSObject::SetLocalPropertyIgnoreAttributes(
1194 result, factory->length_symbol(), 1194 result, factory->length_symbol(),
1195 factory->undefined_value(), DONT_ENUM)); 1195 factory->undefined_value(), DONT_ENUM));
1196 1196
1197 #ifdef DEBUG 1197 #ifdef DEBUG
1198 LookupResult lookup(isolate); 1198 LookupResult lookup(isolate);
1199 result->LocalLookup(heap->length_symbol(), &lookup); 1199 result->LocalLookup(heap->length_symbol(), &lookup);
1200 ASSERT(lookup.IsProperty() && (lookup.type() == FIELD)); 1200 ASSERT(lookup.IsFound() && (lookup.type() == FIELD));
1201 ASSERT(lookup.GetFieldIndex() == Heap::kArgumentsLengthIndex); 1201 ASSERT(lookup.GetFieldIndex() == Heap::kArgumentsLengthIndex);
1202 1202
1203 ASSERT(result->map()->inobject_properties() > Heap::kArgumentsLengthIndex); 1203 ASSERT(result->map()->inobject_properties() > Heap::kArgumentsLengthIndex);
1204 1204
1205 // Check the state of the object. 1205 // Check the state of the object.
1206 ASSERT(result->HasFastProperties()); 1206 ASSERT(result->HasFastProperties());
1207 ASSERT(result->HasFastElements()); 1207 ASSERT(result->HasFastElements());
1208 #endif 1208 #endif
1209 } 1209 }
1210 1210
(...skipping 1163 matching lines...) Expand 10 before | Expand all | Expand 10 after
2374 return from + sizeof(NestingCounterType); 2374 return from + sizeof(NestingCounterType);
2375 } 2375 }
2376 2376
2377 2377
2378 // Called when the top-level V8 mutex is destroyed. 2378 // Called when the top-level V8 mutex is destroyed.
2379 void Bootstrapper::FreeThreadResources() { 2379 void Bootstrapper::FreeThreadResources() {
2380 ASSERT(!IsActive()); 2380 ASSERT(!IsActive());
2381 } 2381 }
2382 2382
2383 } } // namespace v8::internal 2383 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ast.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698