Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 9280007: Replaced LookupResult::IsProperty by LookupResult::IsFound where possible. (Closed)

Created:
8 years, 11 months ago by Sven Panne
Modified:
8 years, 11 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Replaced LookupResult::IsProperty by LookupResult::IsFound where possible. Yak shaving for map sharing with accessor properties contd.: When CALLBACKS can have map transitions, simply looking at the property type is not sufficient anymore to decide if a property is there or not. One has to look at the actual contents of the descriptor entry then, but this breaks down sometimes when the lookup is being done with a NULL holder. Luckily enough, we can oftren replace IsProperty by the simpler IsFound, because we inspect the type immediately afterwards, anyway. Committed: https://code.google.com/p/v8/source/detail?r=10474

Patch Set 1 #

Patch Set 2 : 2 fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -34 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/stub-cache-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ast.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/stub-cache-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/runtime.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/stub-cache-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
8 years, 11 months ago (2012-01-23 07:58:43 UTC) #1
danno
8 years, 11 months ago (2012-01-23 11:08:28 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698