Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 9280004: Merge 105393 - [Chromium] Random characters got rendered as empty boxes or with incorrect glyphs ... (Closed)

Created:
8 years, 11 months ago by bashi
Modified:
8 years, 11 months ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/963/
Visibility:
Public.

Description

Merge 105393 - [Chromium] Random characters got rendered as empty boxes or with incorrect glyphs even when a font is present https://bugs.webkit.org/show_bug.cgi?id=76508 Patch by Kazuhiro Inaba <kinaba@chromium.org>; on 2012-01-19 Reviewed by Kent Tamura. Wrapped GetGlyphIndices() API calls so that when they failed we trigger font loading outside the sandbox and retry the call. No new auto tests since the bug involves the system's occasional cache behavior and thus there's no reliable way to reproduce and test the situation. * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::getGlyphIndices): GDI call wrapper ensuring fonts to be loaded. (WebCore::initSpaceGlyph): Changed to use the wrapper function. (WebCore::fillBMPGlyphs): Changed to use the wrapper function. Introduced scoped HDC management by HWndDC. (WebCore::GlyphPage::fill): TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=105593

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -23 lines) Patch
M Source/WebCore/platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp View 7 chunks +46 lines, -23 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
bashi
8 years, 11 months ago (2012-01-23 05:35:27 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698