Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 9274004: Take the Extension Storage API out of experimental. (Closed)

Created:
8 years, 11 months ago by not at google - send to devlin
Modified:
8 years, 11 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Take the Extension Storage API out of experimental: - add "storage" permissions to exension_permission_set. - s/experimental.storage/storage/g (file contents and names). - s/EXPERIMENTAL_STORAGE/STORAGE/g (ditto). - re-sort anything out of order as a result. - regenerate docs. BUG=92589 TEST=browser_tests --gtest_filter=*ExtensionSettings* --gtest_also_run_disabled_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118656

Patch Set 1 #

Patch Set 2 : docs #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 4

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -1732 lines) Patch
M chrome/browser/extensions/extension_event_names.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/settings/settings_api.h View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/settings/settings_namespace.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/common_resources.grd View 1 2 2 chunks +1 line, -1 line 0 comments Download
D chrome/common/extensions/api/experimental.storage.json View 1 chunk +0 lines, -162 lines 0 comments Download
M chrome/common/extensions/api/extension_api.cc View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
A + chrome/common/extensions/api/storage.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/api_index.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/api/storage/stylizr.zip View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/storage/stylizr/options.js View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/storage/stylizr/popup.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/experimental.html View 1 1 chunk +1 line, -2 lines 0 comments Download
D chrome/common/extensions/docs/experimental.storage.html View 1 2 3 4 7 chunks +63 lines, -1466 lines 0 comments Download
M chrome/common/extensions/docs/js/api_page_generator.js View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/samples.html View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
A chrome/common/extensions/docs/static/experimental.storage.html View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
A + chrome/common/extensions/docs/storage.html View 1 2 3 4 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/common/extensions/extension_permission_set.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/extension_permission_set.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_permission_set_unittest.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/extensions/custom_bindings_util.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/renderer_resources.grd View 1 2 2 chunks +1 line, -1 line 0 comments Download
D chrome/renderer/resources/extensions/experimental.storage_custom_bindings.js View 1 chunk +0 lines, -47 lines 0 comments Download
A + chrome/renderer/resources/extensions/storage_custom_bindings.js View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/extension_api/events.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/extension_api/fire_event.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_scripts/extension_api/manifest.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/settings/simple_test/background.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/settings/simple_test/manifest.json View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/settings/split_incognito/background.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/settings/split_incognito/manifest.json View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
not at google - send to devlin
Ready to submit... when ready.
8 years, 11 months ago (2012-01-23 00:27:00 UTC) #1
Aaron Boodman
http://codereview.chromium.org/9274004/diff/6001/chrome/common/extensions/docs/experimental.storage.html File chrome/common/extensions/docs/experimental.storage.html (left): http://codereview.chromium.org/9274004/diff/6001/chrome/common/extensions/docs/experimental.storage.html#oldcode1 chrome/common/extensions/docs/experimental.storage.html:1: <!DOCTYPE html><!-- This page is a placeholder for generated ...
8 years, 11 months ago (2012-01-23 01:51:32 UTC) #2
not at google - send to devlin
What do you think about a user prompt? I presume that the way I've set ...
8 years, 11 months ago (2012-01-23 03:59:23 UTC) #3
Aaron Boodman
On Sun, Jan 22, 2012 at 7:59 PM, <kalman@chromium.org> wrote: > What do you think ...
8 years, 11 months ago (2012-01-23 04:22:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/9274004/9003
8 years, 11 months ago (2012-01-23 04:54:43 UTC) #5
commit-bot: I haz the power
8 years, 11 months ago (2012-01-23 06:27:51 UTC) #6
Try job failure for 9274004-9003 (retry) (retry) on linux_rel for step
"net_unittests".
It's a second try, previously, step "net_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698