Cleanup: Remove static storage for variables in an unnamed namespace.

Cleanup: Remove static storage for variables in an unnamed namespace.

BUG=none
TEST=none
R=binji

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119535

[akalin, 2012-01-26 03:50:33]

sync lgtm

[Ami GONE FROM CHROMIUM, 2012-01-26 03:51:33]

drive-by

https://chromiumcodereview.appspot.com/9271061/diff/1/media/audio/linux/alsa_...
File media/audio/linux/alsa_output.cc (right):

https://chromiumcodereview.appspot.com/9271061/diff/1/media/audio/linux/alsa_...
media/audio/linux/alsa_output.cc:52: namespace {
media/ code actually goes the other way - preferring file-static over anon
namespace.  Would you mind reverting this file from this CL?
(and remove the namespace if you're feeling charitable, or else I'll do it)

[James Hawkins, 2012-01-26 03:53:01]

https://chromiumcodereview.appspot.com/9271061/diff/1/media/audio/linux/alsa_...
File media/audio/linux/alsa_output.cc (right):

https://chromiumcodereview.appspot.com/9271061/diff/1/media/audio/linux/alsa_...
media/audio/linux/alsa_output.cc:52: namespace {
On 2012/01/26 03:51:34, Ami Fischman wrote:
> media/ code actually goes the other way - preferring file-static over anon
> namespace.  Would you mind reverting this file from this CL?
> (and remove the namespace if you're feeling charitable, or else I'll do it)

Why would we use two different styles in the same code base?

[Ami GONE FROM CHROMIUM, 2012-01-26 03:57:01]

On 2012/01/26 03:53:01, James Hawkins wrote:
>
https://chromiumcodereview.appspot.com/9271061/diff/1/media/audio/linux/alsa_...
> File media/audio/linux/alsa_output.cc (right):
> 
>
https://chromiumcodereview.appspot.com/9271061/diff/1/media/audio/linux/alsa_...
> media/audio/linux/alsa_output.cc:52: namespace {
> On 2012/01/26 03:51:34, Ami Fischman wrote:
> > media/ code actually goes the other way - preferring file-static over anon
> > namespace.  Would you mind reverting this file from this CL?
> > (and remove the namespace if you're feeling charitable, or else I'll do it)
> 
> Why would we use two different styles in the same code base?

If by "the same code base" you mean the chromium code base, then the answer is
that it has evolved that way due to a lack of style guide guidance.

There are pros and cons to each style, obvs.  The media team has discussed this
and prefers the file-static style, so has standardized on that (because before
we had a mix of both styles in the media codebase).

[James Hawkins, 2012-01-26 04:13:02]

https://chromiumcodereview.appspot.com/9271061/diff/1/media/audio/linux/alsa_...
File media/audio/linux/alsa_output.cc (right):

https://chromiumcodereview.appspot.com/9271061/diff/1/media/audio/linux/alsa_...
media/audio/linux/alsa_output.cc:52: namespace {
On 2012/01/26 03:53:02, James Hawkins wrote:
> On 2012/01/26 03:51:34, Ami Fischman wrote:
> > media/ code actually goes the other way - preferring file-static over anon
> > namespace.  Would you mind reverting this file from this CL?
> > (and remove the namespace if you're feeling charitable, or else I'll do it)
> 
> Why would we use two different styles in the same code base?

Removed namespace and added back static per-preference of media/

[Ami GONE FROM CHROMIUM, 2012-01-26 04:22:40]

media/ LGTM
Thanks!

[Lambros, 2012-01-26 18:04:10]

remoting/ LGTM

[binji, 2012-01-26 18:39:19]

lgtm

[commit-bot: I haz the power, 2012-01-27 23:37:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jhawkins@chromium.org/9271061/3003

[commit-bot: I haz the power, 2012-01-27 23:37:27]

Presubmit check for 9271061-3003 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
You might be calling functions intended only for testing from
production code.  It is OK to ignore this warning if you know what
you are doing, as the heuristics used to detect the situation are
not perfect.  The commit queue will not block on this warning.
Email joi@chromium.org if you have questions.
  chrome/browser/sync/syncable/syncable.cc:2154
    EntryKernel* entry = GetPossibleLastChildForTest(lock, parent_id);

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
webkit/plugins/npapi/plugin_list.cc,base/path_service.cc,content/renderer/gpu/renderer_gl_context.cc,content/renderer/render_thread_impl.cc,printing/printing_context_gtk.cc,base/nix/mime_util_xdg.cc,printing/printed_document.cc,base/tracked_objects.cc,webkit/plugins/npapi/webplugin_impl.cc,webkit/plugins/ppapi/ppapi_plugin_instance.cc,printing/backend/print_backend_cups.cc,base/linux_util.cc

Presubmit checks took 2.8s to calculate.