Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2082)

Unified Diff: content/browser/tab_contents/tab_contents.h

Issue 9271054: Send replies to sync IPCs from swapped out renderers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Send JS replies to right RVH. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tab_contents/tab_contents.h
diff --git a/content/browser/tab_contents/tab_contents.h b/content/browser/tab_contents/tab_contents.h
index 5dda23e323bd806975e4d91c205abc9649b3a1df..263883c893920b06cba41f92bc66c91fcb558ae7 100644
--- a/content/browser/tab_contents/tab_contents.h
+++ b/content/browser/tab_contents/tab_contents.h
@@ -268,14 +268,14 @@ class CONTENT_EXPORT TabContents
WindowOpenDisposition disposition,
int64 source_frame_id,
const content::GlobalRequestID& transferred_global_request_id) OVERRIDE;
- virtual void RunJavaScriptMessage(const RenderViewHost* rvh,
+ virtual void RunJavaScriptMessage(RenderViewHost* rvh,
const string16& message,
const string16& default_prompt,
const GURL& frame_url,
ui::JavascriptMessageType type,
IPC::Message* reply_msg,
bool* did_suppress_message) OVERRIDE;
- virtual void RunBeforeUnloadConfirm(const RenderViewHost* rvh,
+ virtual void RunBeforeUnloadConfirm(RenderViewHost* rvh,
const string16& message,
IPC::Message* reply_msg) OVERRIDE;
virtual content::RendererPreferences GetRendererPrefs(
@@ -336,7 +336,8 @@ class CONTENT_EXPORT TabContents
virtual void CreateViewAndSetSizeForRVH(RenderViewHost* rvh) OVERRIDE;
// Overridden from JavaScriptDialogDelegate:
- virtual void OnDialogClosed(IPC::Message* reply_msg,
+ virtual void OnDialogClosed(RenderViewHost* rvh,
+ IPC::Message* reply_msg,
bool success,
const string16& user_input) OVERRIDE;
virtual gfx::NativeWindow GetDialogRootWindow() const OVERRIDE;
« no previous file with comments | « content/browser/tab_contents/render_view_host_manager_unittest.cc ('k') | content/browser/tab_contents/tab_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698