Inserted string validation as separate task in compiler.

frog/leg/ssa/builder.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Interceptors {
   Compiler compiler;
   Interceptors(Compiler this.compiler);
 
   SourceString mapOperatorToMethodName(Operator op) {
     String name = op.source.stringValue;
@@ skipping 1128 matching lines @@
 
   void visitLiteralDouble(LiteralDouble node) {
     push(new HLiteral(node.value, HType.DOUBLE));
   }
 
   void visitLiteralBool(LiteralBool node) {
     push(new HLiteral(node.value, HType.BOOLEAN));
   }
 
   void visitLiteralString(LiteralString node) {
-    push(new HLiteral(new QuotedString.explicit(node.value), HType.STRING));
+    push(new HLiteral(node.quotedString, HType.STRING));
   }
 
   void visitLiteralNull(LiteralNull node) {
     push(new HLiteral(null, HType.UNKNOWN));
   }
 
   visitNodeList(NodeList node) {
     for (Link<Node> link = node.nodes; !link.isEmpty(); link = link.tail) {
       visit(link.head);
     }
@@ skipping 90 matching lines @@
     definitions = joinDefinitions(joinBlock, thenDefinitions, definitions);
     HPhi phi = new HPhi.manyInputs(null, [thenInstruction, elseInstruction]);
     joinBlock.addPhi(phi);
     stack.add(phi);
   }
 
   visitStringInterpolation(StringInterpolation node) {
     Operator op = new Operator.synthetic("+");
     HInstruction target = new HStatic(interceptors.getOperatorInterceptor(op));
     add(target);
-    // Ensure that string literals are marked with the correct quoting
-    // style and presence of quotes (left quote only on the first one,
-    // right quote only on the last one).
-    int quoteFlags = QuotedString.flagsFromLeftQuote(node.string.value);
-    // The loop is complicated because we have to do something extra for
-    // the *last* element. To do that, we handle the [string] of a part
-    // in the next iteration, or after the loop for the last element.
-    int firstPartFlags = quoteFlags | QuotedString.HAS_LEFT_QUOTE;
-    push(new HLiteral(new QuotedString(node.string.value, firstPartFlags),
-                      HType.STRING));
-
-    SourceString string = null;
+    visit(node.string);
+    // Handle the parts here, to avoid recreating [target].
     for (StringInterpolationPart part in node.parts) {
       HInstruction prefix = pop();
-      if (string != null) {
-        push(new HLiteral(new QuotedString(string, quoteFlags),
-                          HType.STRING));
-        push(new HAdd(target, prefix, pop()));
-        prefix = pop();
-      }
       visit(part.expression);
       push(new HAdd(target, prefix, pop()));
-      string = part.string.value;
+      prefix = pop();
+      visit(part.string);
+      push(new HAdd(target, prefix, pop()));
     }
-    HInstruction prefix = pop();
-    int lastPartFlags = quoteFlags | QuotedString.HAS_RIGHT_QUOTE;
-    push(new HLiteral(new QuotedString(string, lastPartFlags),
-                      HType.STRING));
-    push(new HAdd(target, prefix, pop()));
   }
 
   visitStringInterpolationPart(StringInterpolationPart node) {
     // The parts are iterated in visitStringInterpolation.
     unreachable();
   }
 
   visitEmptyStatement(EmptyStatement node) {
     compiler.unimplemented('SsaBuilder.visitEmptyStatement',
                            node: node);
@@ skipping 107 matching lines @@
   }
 
   visitCatchBlock(CatchBlock node) {
     compiler.unimplemented('SsaBuilder.visitCatchBlock', node: node);
   }
 
   visitTypedef(Typedef node) {
     compiler.unimplemented('SsaBuilder.visitTypedef', node: node);
   }
 }