Inserted string validation as separate task in compiler.

frog/leg/tree/nodes.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 interface Visitor<R> {
   R visitBlock(Block node);
   R visitBreakStatement(BreakStatement node);
   R visitCatchBlock(CatchBlock node);
   R visitClassNode(ClassNode node);
   R visitConditional(Conditional node);
@@ skipping 594 matching lines @@
       case Keyword.TRUE: return true;
       case Keyword.FALSE: return false;
       default:
         (this.handler)(token, "not a bool ${token.value}");
     }
   }
 
   accept(Visitor visitor) => visitor.visitLiteralBool(this);
 }
 
+
+class StringQuoting {
+  static final StringQuoting SINGLELINE_DQ =
+      const StringQuoting($DQ, false, false);

[ahe, 2012/01/25 08:39:44]

Is is possible to use named arguments here?

[karlklose, 2012/01/25 08:47:26]

It would be nice to have named arguments here.

[Lasse Reichstein Nielsen, 2012/01/26 10:14:20]

Done.

+  static final StringQuoting RAW_SINGLELINE_DQ =
+      const StringQuoting($DQ, true, false);
+  static final StringQuoting MULTILINE_DQ =
+      const StringQuoting($DQ, false, true);
+  static final StringQuoting RAW_MULTILINE_DQ =
+      const StringQuoting($DQ, true, true);
+  static final StringQuoting SINGLELINE_SQ =
+      const StringQuoting($SQ, false, false);
+  static final StringQuoting RAW_SINGLELINE_SQ =
+      const StringQuoting($SQ, true, false);
+  static final StringQuoting MULTILINE_SQ =
+      const StringQuoting($SQ, false, true);
+  static final StringQuoting RAW_MULTILINE_SQ =
+      const StringQuoting($SQ, true, true);
+  static final List<StringQuoting> mapping = const <StringQuoting>[
+    SINGLELINE_DQ,
+    RAW_SINGLELINE_DQ,
+    MULTILINE_DQ,
+    RAW_MULTILINE_DQ,
+    SINGLELINE_SQ,
+    RAW_SINGLELINE_SQ,
+    MULTILINE_DQ,
+    RAW_MULTILINE_SQ
+  ];
+  final bool raw;
+  final bool multiline;
+  final int quote;
+  const StringQuoting(this.quote, this.raw, this.multiline);
+  String get quoteChar() => quote === $DQ ? '"' : "'";
+
+  int get leftQuoteLength() => (raw ? 1 : 0) + (multiline ? 3 : 1);
+  int get rightQuoteLength() => multiline ? 3 : 1;
+  static StringQuoting get(int quote, bool raw, bool multiline) =>
+    mapping[(raw ? 1 : 0) + (multiline ? 2 : 0) + (quote === $SQ ? 4 : 0)];
+}
+
+/**
+ * A wrapper around a SourceString that stores extra information about
+ * the (potentially implicit) quoting style of the original string.
+ * For most strings, the quotes are included in the [source], but
+ * parts of strings from a string interpolation might be missing one or
+ * both quotes.
+ */
+class QuotedString {
+  // A source-backed string literal without the quotes.
+  final SourceString source;
+  // The quoting style of the original string literal.
+  // Whether it's raw or multi-line impacts the interpretation of
+  // the string literal content. Whether it's single- or double-quoted
+  // is only used as a hint later.
+  final StringQuoting quoting;
+  /** Actual length of the corresponding, parsed, Dart string */
+  final int length;
+
+  const QuotedString(this.source, this.quoting, this.length);
+  /**
+   * Construct a [QuotedString] containing exactly the given string.
+   * The choice of quoting ensures that all characters of the original
+   * string are valid and has their exact meaning.
+   */
+  QuotedString.literal(String string)
+      : source = new SourceString(string),
+        quoting = StringQuoting.RAW_MULTILINE_DQ,
+        length = string.length;
+
+  bool isEmpty() => source.isEmpty();
+  Iterator<int> iterator() => source.iterator();
+
+  bool definitlyEquals(QuotedString other) {
+    return source === other.source && quoting === other.quoting;
+  }
+}
+
+
 class LiteralString extends Literal<SourceString> {
+  /** Set on validated string literals. */
+  QuotedString quotedString = null;

[ahe, 2012/01/25 08:39:44]

I think this should be final.

[Lasse Reichstein Nielsen, 2012/01/26 10:14:20]

It is now that we find the value during parsing.

+
   LiteralString(Token token) : super(token, null);
 
   LiteralString asLiteralString() => this;
 
+  bool isValid() => quotedString !== null;

[ahe, 2012/01/25 08:39:44]

This method will answer false for valid strings that haven't been validated yet.

[Lasse Reichstein Nielsen, 2012/01/26 10:14:20]

Yes.
Renaming to isValidated().

+
   SourceString get value() => token.value;
 
   accept(Visitor visitor) => visitor.visitLiteralString(this);
 }
 
 class LiteralNull extends Literal<SourceString> {
   LiteralNull(Token token) : super(token, null);
 
   LiteralNull asLiteralNull() => this;
 
@@ skipping 625 matching lines @@
 
   visitChildren(Visitor visitor) {
     formals.accept(visitor);
     block.accept(visitor);
   }
 
   Token getBeginToken() => catchKeyword;
 
   Token getEndToken() => block.getEndToken();
 }