Inserted string validation as separate task in compiler.

frog/leg/compiler.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class WorkItem {
   final Element element;
   TreeElements resolutionTree;
   Function run;
   Map<int, BailoutInfo> bailouts = null;
 
@@ skipping 31 matching lines @@
   Namer namer;
   Types types;
 
   CompilerTask measuredTask;
   Element currentElement;
   Element currentLibrary = null; // TODO(ngeoffray): initialize this.
 
   List<CompilerTask> tasks;
   ScannerTask scanner;
   ParserTask parser;
+  StringValidatorTask stringValidator;
   TreeValidatorTask validator;
   ResolverTask resolver;
   TypeCheckerTask checker;
   SsaBuilderTask builder;
   SsaOptimizerTask optimizer;
   SsaCodeGeneratorTask generator;
   CodeEmitterTask emitter;
   CompileTimeConstantHandler compileTimeConstantHandler;
 
   static final SourceString MAIN = const SourceString('main');
   static final SourceString NO_SUCH_METHOD = const SourceString('noSuchMethod');
 
   Compiler()
       : types = new Types(),
         universe = new Universe(),
         worklist = new Queue<WorkItem>() {
     namer = new Namer(this);
     compileTimeConstantHandler = new CompileTimeConstantHandler(this);
     scanner = new ScannerTask(this);
     parser = new ParserTask(this);
+    stringValidator = new StringValidatorTask(this);
     validator = new TreeValidatorTask(this);
     resolver = new ResolverTask(this);
     checker = new TypeCheckerTask(this);
     builder = new SsaBuilderTask(this);
     optimizer = new SsaOptimizerTask(this);
     generator = new SsaCodeGeneratorTask(this);
     emitter = new CodeEmitterTask(this);
-    tasks = [scanner, parser, resolver, checker, builder, optimizer, generator,
-             emitter, compileTimeConstantHandler];
+    tasks = [scanner, parser, stringValidator, resolver, checker, builder,
+             optimizer, generator, emitter, compileTimeConstantHandler];
   }
 
   void ensure(bool condition) {
     if (!condition) cancel('failed assertion in leg');
   }
 
   void unimplemented(String methodName,
                      [Node node, Token token, HInstruction instruction]) {
     cancel("$methodName not implemented", node, token, instruction);
   }
@@ skipping 85 matching lines @@
         currentElement = work.element;
         (work.run)(this);
       }
       enqueueInvokedInstanceMethods();
     } while (!worklist.isEmpty());
     emitter.assembleProgram();
   }
 
   TreeElements analyzeElement(Element element) {
     Node tree = parser.parse(element);
+    stringValidator.validate(tree);
     validator.validate(tree);
     TreeElements elements = resolver.resolve(element);
     checker.check(tree, elements);
     return elements;
   }
 
   TreeElements analyze(WorkItem work) {
     work.resolutionTree = analyzeElement(work.element);
     return work.resolutionTree;
   }
@@ skipping 45 matching lines @@
 
   void registerDynamicSetter(SourceString methodName) {
     universe.invokedSetters.add(methodName);
   }
 
   void registerInstantiatedClass(ClassElement element) {
     universe.instantiatedClasses.add(element);
   }
 
   Element resolveType(ClassElement element) {
-    parser.parse(element);
+    Node tree = parser.parse(element);
+    stringValidator.validate(tree);
     resolver.resolveType(element);
     return element;
   }
 
   Element resolveSignature(FunctionElement element) {
-    parser.parse(element);
+    Node tree = parser.parse(element);
+    stringValidator.validate(tree);
     resolver.resolveSignature(element);
     return element;
   }
 
   reportWarning(Node node, var message) {}
   reportError(Node node, var message) {}
 
   Script readScript(String filename) {
     unimplemented('Compiler.readScript');
   }
@@ skipping 28 matching lines @@
 
 class CompilerCancelledException implements Exception {
   final String reason;
   CompilerCancelledException(this.reason);
 
   String toString() {
     String banner = 'compiler cancelled';
     return (reason !== null) ? '$banner: $reason' : '$banner';
   }
 }