frog/lib/string_base.dart - Issue 9270048: Lots of frog cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: frog/lib/string_base.dart

Issue 9270048: Lots of frog cleanup (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: frog/lib/string_base.dart

diff --git a/frog/lib/string_base.dart b/frog/lib/string_base.dart

index fa7eb1d6f5b9d7703612cb5a92365de3b19cdf35..3903a46aba3f0b38a365b28942865dd375a5b43c 100644

--- a/frog/lib/string_base.dart

+++ b/frog/lib/string_base.dart

@@ -13,6 +13,8 @@ if (Object.getPrototypeOf(charCodes) !== Array.prototype) {

}

return String.fromCharCode.apply(null, charCodes);

''' {

+ // we may need to iterate over charCodes

+ var i = charCodes.iterator(); i.next(); i.hasNext();

new ListFactory.from(charCodes); // ensure List.from is generated

}

« frog/gen.dart ('K') | « frog/lib/num.dart ('k') | frog/library.dart » ('j') | no next file with comments »