Fix up and test FrozenElementList.

client/html/src/ElementWrappingImplementation.dart

Index: client/html/src/ElementWrappingImplementation.dart
diff --git a/client/html/src/ElementWrappingImplementation.dart b/client/html/src/ElementWrappingImplementation.dart
index a10b510fb39e63c0527ff1aa4a16d585c90a7799..8f9abb72c0912f01c9f612180b4ec7d5751087e5 100644
--- a/client/html/src/ElementWrappingImplementation.dart
+++ b/client/html/src/ElementWrappingImplementation.dart
@@ -133,37 +133,46 @@ class _ChildrenElementList implements ElementList {
 
 class FrozenElementList implements ElementList {
   final _ptr;
+  List<Element> _list;
 
   FrozenElementList._wrap(this._ptr);
 
+  List<Element> _toList() {

[Jacob, 2012/01/21 01:33:47]

This list is frozen so I don't understand why copying it is required.
I'm alright with checking in this change if you add a big TODO indicating this
is a significant potential performance bottleneck.

[nweiz, 2012/01/23 21:06:52]

This is just a convenience method to make it easier to implement #map, #forEach,
and #filter by using the underlying List implementation. It's only used when the
entire list is going to be iterated over anyway, although I suppose it adds some
list-creation overhead. I'll re-implement #forEach by hand and write #map and
#filter in terms of that.

+    if (_list == null) {
+      _list = new List(_ptr.length);
+      for (int i = 0, len = _ptr.length; i < len; i++) {
+        _list[i] = LevelDom.wrapElement(_ptr[i]);
+      }
+    }
+    return _list;
+  }
+
   Element get first() {
     return this[0];
   }
 
-  void forEach(void f(Element element)) {
-    final length = _ptr.length;
-    for (var i = 0; i < length; i++) {
-      f(LevelDom.wrapElement(_ptr[i]));
-    }
-  }
+  void forEach(void f(Element element)) => _toList().forEach(f);
 
-  Collection map(f(Element element)) {
-    //TODO(jacobr): Implement this.
-    throw 'Not implemented yet.';
-  }
+  Collection map(f(Element element)) => _toList().map(f);
 
-  Collection<Element> filter(bool f(Element element)) {
-    //TODO(jacobr): Implement this.
-    throw 'Not implemented yet.';
-  }
+  Collection<Element> filter(bool f(Element element)) => _toList().filter(f);
 
   bool every(bool f(Element element)) {
-    //TODO(jacobr): Implement this.
-    throw 'Not implemented yet.';
+    for(Element element in this) {
+      if (!f(element)) {
+        return false;
+      }
+    };
+    return true;
   }
 
   bool some(bool f(Element element)) {
-    throw 'Not impl yet. todo(jacobr)';
+    for(Element element in this) {
+      if (f(element)) {
+        return true;
+      }
+    };
+    return false;
   }
 
   bool isEmpty() {
@@ -210,35 +219,33 @@ class FrozenElementList implements ElementList {
   }
 
   void setRange(int start, int length, List from, [int startFrom = 0]) {
-    throw const NotImplementedException();
+    throw const UnsupportedOperationException('');
   }
 
   void removeRange(int start, int length) {
-    throw const NotImplementedException();
+    throw const UnsupportedOperationException('');
   }
 
   void insertRange(int start, int length, [initialValue = null]) {
-    throw const NotImplementedException();
+    throw const UnsupportedOperationException('');
   }
 
-  List getRange(int start, int length) {
-    throw const NotImplementedException();
-  }
+  List getRange(int start, int length) => Lists.getRange(this, start, length);
 
-  int indexOf(Element element, [int start = 0]) {
-    throw 'Not impl yet. todo(jacobr)';
-  }
+  int indexOf(Element element, [int start = 0]) =>
+    Lists.indexOf(this, element, start, this.length);
 
   int lastIndexOf(Element element, [int start = null]) {
-    throw 'Not impl yet. todo(jacobr)';
+    if (start === null) start = length - 1;
+    return Lists.lastIndexOf(this, element, start);
   }
 
   void clear() {
-    throw 'Not impl yet. todo(jacobr)';
+    throw const UnsupportedOperationException('');
   }
 
   Element removeLast() {
-    throw 'Not impl yet. todo(jacobr)';
+    throw const UnsupportedOperationException('');
   }
 
   Element last() {