Make a separate histogram for MatchComplete Final Status'es and

chrome/browser/prerender/prerender_contents.h

Index: chrome/browser/prerender/prerender_contents.h
===================================================================
--- chrome/browser/prerender/prerender_contents.h	(revision 118385)
+++ chrome/browser/prerender/prerender_contents.h	(working copy)
@@ -81,6 +81,12 @@
   };
   typedef std::list<PendingPrerenderData> PendingPrerenderList;
 
+  enum MatchCompleteStatus {

[dominich, 2012/01/20 22:23:37]

Needs a comment explaining what this is.

[tburkard, 2012/01/20 23:23:00]

Done.

+    MC_DEFAULT,
+    MC_REPLACED,
+    MC_REPLACEMENT
+  };
+
   virtual ~PrerenderContents();
 
   bool Init();
@@ -106,6 +112,8 @@
   const content::Referrer& referrer() const { return referrer_; }
   bool has_stopped_loading() const { return has_stopped_loading_; }
   bool prerendering_has_started() const { return prerendering_has_started_; }
+  MatchCompleteStatus mc_status() const { return mc_status_; }

[dominich, 2012/01/20 22:23:37]

This is more of a style question: If the get and set are this simple and both
public, is there any reason not to just make the member public directly?

[tburkard, 2012/01/20 23:23:00]

In general that's not the way things are usually done.  Unless you have an all
public struct, member variables should always be private, and provide
getters/setters.

On 2012/01/20 22:23:37, dominich wrote:

+  void set_mc_status(MatchCompleteStatus status) { mc_status_ = status; }
 
   // Sets the parameter to the value of the associated RenderViewHost's child id
   // and returns a boolean indicating the validity of that id.
@@ -269,6 +277,8 @@
 
   bool prerendering_has_started_;
 
+  MatchCompleteStatus mc_status_;

[dominich, 2012/01/20 22:23:37]

Needs a comment explaining what it is.

[dominich, 2012/01/20 22:23:37]

mc_status_ should be match_complete_status_

[tburkard, 2012/01/20 23:23:00]

Done.

[tburkard, 2012/01/20 23:23:00]

Since this is used so frequently, mc_status is much more
convenient, esp. for getters/setters.

On 2012/01/20 22:23:37, dominich wrote:

+
   // Tracks whether or not prerendering has been cancelled by calling Destroy.
   // Used solely to prevent double deletion.
   bool prerendering_has_been_cancelled_;