Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: chrome/browser/prerender/prerender_manager_unittest.cc

Issue 9270018: Make a separate histogram for MatchComplete Final Status'es and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prerender/prerender_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_manager_unittest.cc
===================================================================
--- chrome/browser/prerender/prerender_manager_unittest.cc (revision 118385)
+++ chrome/browser/prerender/prerender_manager_unittest.cc (working copy)
@@ -446,7 +446,7 @@
}
// Tests that a PrerenderManager created for a browser session in the control
-// group will not be able to override FINAL_STATUS_CONTROL_GROUP.
+// group works as expected.
TEST_F(PrerenderManagerTest, ControlGroup) {
RestorePrerenderMode restore_prerender_mode;
PrerenderManager::SetMode(
@@ -455,11 +455,43 @@
DummyPrerenderContents* prerender_contents =
prerender_manager()->CreateNextPrerenderContents(
url,
- FINAL_STATUS_CONTROL_GROUP);
+ FINAL_STATUS_MANAGER_SHUTDOWN);
EXPECT_TRUE(prerender_manager()->AddSimplePrerender(url));
EXPECT_FALSE(prerender_contents->has_started());
}
+// Tests that a PrerenderManager created for a browser session in the control
+// group works as expected if the site gets visited.
+TEST_F(PrerenderManagerTest, ControlGroupVisited) {
+ RestorePrerenderMode restore_prerender_mode;
+ PrerenderManager::SetMode(
+ PrerenderManager::PRERENDER_MODE_EXPERIMENT_CONTROL_GROUP);
+ GURL url("http://www.google.com/");
+ DummyPrerenderContents* prerender_contents =
+ prerender_manager()->CreateNextPrerenderContents(
+ url,
+ FINAL_STATUS_WOULD_HAVE_BEEN_USED);
+ EXPECT_TRUE(prerender_manager()->AddSimplePrerender(url));
+ EXPECT_FALSE(prerender_contents->has_started());
+ ASSERT_EQ(prerender_contents, prerender_manager()->GetEntry(url));
+}
+
+// Tests that a PrerenderManager correctly handles the case of visitiung a page
+// when the NoUseGroup is enabled.
+TEST_F(PrerenderManagerTest, NoUseGroupVisited) {
+ RestorePrerenderMode restore_prerender_mode;
+ PrerenderManager::SetMode(
+ PrerenderManager::PRERENDER_MODE_EXPERIMENT_NO_USE_GROUP);
+ GURL url("http://www.google.com/");
+ DummyPrerenderContents* prerender_contents =
+ prerender_manager()->CreateNextPrerenderContents(
+ url,
+ FINAL_STATUS_WOULD_HAVE_BEEN_USED);
+ EXPECT_TRUE(prerender_manager()->AddSimplePrerender(url));
+ EXPECT_TRUE(prerender_contents->has_started());
+ ASSERT_EQ(prerender_contents, prerender_manager()->GetEntry(url));
+}
+
// Tests that prerendering is cancelled when the source render view does not
// exist. On failure, the DCHECK in CreatePrerenderContents() above should be
// triggered.
« no previous file with comments | « chrome/browser/prerender/prerender_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698