Make a separate histogram for MatchComplete Final Status'es and

chrome/browser/prerender/prerender_manager.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PRERENDER_PRERENDER_MANAGER_H_
 #define CHROME_BROWSER_PRERENDER_PRERENDER_MANAGER_H_
 #pragma once
 
 #include <list>
 #include <string>
@@ skipping 183 matching lines @@
   // destroyed as well.
   //
   // If the CLEAR_PRERENDER_HISTORY bit is set, the prerender history is
   // cleared, including any entries newly created by destroying them in
   // response to the CLEAR_PRERENDER_CONTENTS flag.
   //
   // Intended to be used when clearing the cache or history.
   void ClearData(int clear_flags);
 
   // Record a final status of a prerendered page in a histogram.
   void RecordFinalStatus(Origin origin,

[dominich, 2012/01/20 22:23:37]

Does this need to be public or can it be removed in favour of the new method?

                          uint8 experiment_id,
                          FinalStatus final_status) const;
 
+  // Record a final status of a prerendered page in a histogram.
+  // This variation allows specifying whether prerendering had been started
+  // (necessary to flag MatchComplete dummies).
+  void RecordFinalStatusWithMatchCompleteStatus(
+      Origin origin,
+      uint8 experiment_id,
+      PrerenderContents::MatchCompleteStatus mc_status,
+      FinalStatus final_status) const;
+
   const Config& config() const { return config_; }
   Config& mutable_config() { return config_; }
 
   PrerenderTracker* prerender_tracker() { return prerender_tracker_; }
 
   // Adds a condition. This is owned by the PrerenderManager.
   void AddCondition(const PrerenderCondition* condition);
 
   bool IsTopSite(const GURL& url);
 
@@ skipping 18 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(PrerenderManagerTest, ClearTest);
   FRIEND_TEST_ALL_PREFIXES(PrerenderManagerTest, ControlGroup);
   FRIEND_TEST_ALL_PREFIXES(PrerenderManagerTest, DropOldestRequestTest);
   FRIEND_TEST_ALL_PREFIXES(PrerenderManagerTest, DropSecondRequestTest);
   FRIEND_TEST_ALL_PREFIXES(PrerenderManagerTest, ExpireTest);
   FRIEND_TEST_ALL_PREFIXES(PrerenderManagerTest, FoundTest);
   FRIEND_TEST_ALL_PREFIXES(PrerenderManagerTest, FragmentMatchesFragmentTest);
   FRIEND_TEST_ALL_PREFIXES(PrerenderManagerTest, FragmentMatchesPageTest);
   FRIEND_TEST_ALL_PREFIXES(PrerenderManagerTest, PageMatchesFragmentTest);
   FRIEND_TEST_ALL_PREFIXES(PrerenderManagerTest, PendingPrerenderTest);
+  FRIEND_TEST_ALL_PREFIXES(PrerenderManagerTest, ControlGroupVisited);
   FRIEND_TEST_ALL_PREFIXES(PrerenderManagerTest, RateLimitInWindowTest);
   FRIEND_TEST_ALL_PREFIXES(PrerenderManagerTest, RateLimitOutsideWindowTest);
   FRIEND_TEST_ALL_PREFIXES(PrerenderManagerTest, SourceRenderViewClosed);
   FRIEND_TEST_ALL_PREFIXES(PrerenderManagerTest, TwoElementPrerenderTest);
 
   struct PrerenderContentsData;
   struct NavigationRecord;
 
   class OnCloseTabContentsDeleter;
 
@@ skipping 105 matching lines @@
 
   // Returns a new Value representing the pages currently being prerendered. The
   // caller is responsible for delete'ing the return value.
   base::Value* GetActivePrerendersAsValue() const;
 
   // Destroys all pending prerenders using FinalStatus.  Also deletes them as
   // well as any swapped out TabContents queued for destruction.
   // Used both on destruction, and when clearing the browsing history.
   void DestroyAllContents(FinalStatus final_status);
 
+  // Helper function to destory a PrerenderContents with the specified

[dominich, 2012/01/20 22:23:37]

nit 'destroy'

[tburkard, 2012/01/20 23:23:00]

Done.

+  // final_status, while at the same time recording that for the MatchComplete
+  // case, that this prerender would have been used.
+  void DestroyAndMarkMatchCompleteAsUsed(PrerenderContents* prerender_contents,
+                                         FinalStatus final_status);
+
   // The configuration.
   Config config_;
 
   // Specifies whether prerendering is currently enabled for this
   // manager. The value can change dynamically during the lifetime
   // of the PrerenderManager.
   bool enabled_;
 
   // The profile that owns this PrerenderManager.
   Profile* profile_;
@@ skipping 49 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(PrerenderManager);
 };
 
 PrerenderManager* FindPrerenderManagerUsingRenderProcessId(
     int render_process_id);
 
 }  // namespace prerender
 
 #endif  // CHROME_BROWSER_PRERENDER_PRERENDER_MANAGER_H_