compiler/java/com/google/dart/compiler/backend/common/TypeHeuristicImplementation.java - Issue 9270016: Issue 932. Checks for various named arguments cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/backend/common/TypeHeuristicImplementation.java

Issue 9270016: Issue 932. Checks for various named arguments cases. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Tweaks for comments, changes in tests. Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/backend/doc/DartDocumentationGenerator.java » ('j') | tests/language/src/NamedParameters3Test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/backend/common/TypeHeuristicImplementation.java

diff --git a/compiler/java/com/google/dart/compiler/backend/common/TypeHeuristicImplementation.java b/compiler/java/com/google/dart/compiler/backend/common/TypeHeuristicImplementation.java

index 41811d0b949dc9728bb5158880830c82b36ad680..53e46b344c5330a6e5321be83112b96e9a5ec7e4 100644

--- a/compiler/java/com/google/dart/compiler/backend/common/TypeHeuristicImplementation.java

+++ b/compiler/java/com/google/dart/compiler/backend/common/TypeHeuristicImplementation.java

@@ -646,8 +646,8 @@ public class TypeHeuristicImplementation implements TypeHeuristic {

}

private InterfaceType substSubType(InterfaceType subType, InterfaceType baseType) {

- List<? extends Type> typeArgs = baseType.getArguments();

- List<? extends Type> typeParams = asInstanceOf(subType, baseType.getElement()).getArguments();

+ List<Type> typeArgs = baseType.getArguments();

+ List<Type> typeParams = asInstanceOf(subType, baseType.getElement()).getArguments();

if (typeArgs != null && !typeArgs.isEmpty()) {

return subType.subst(typeArgs, typeParams);

}

@@ -660,8 +660,8 @@ public class TypeHeuristicImplementation implements TypeHeuristic {

private boolean canInstantiateParametrizedType(Member member) {

InterfaceType iface = member.getHolder();

- List<? extends Type> typeArgs = iface.getArguments();

- List<? extends Type> typeParams = iface.getElement().getTypeParameters();

+ List<Type> typeArgs = iface.getArguments();

+ List<Type> typeParams = iface.getElement().getTypeParameters();

return typeArgs.size() == typeParams.size();

}