Issue 9269027: Revert 118546 because it caused PrerenderHTML5VideoNetwork to timeout on windows and linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9269027: Revert 118546 because it caused PrerenderHTML5VideoNetwork to timeout on windows and linux (Closed)

Created:
8 years, 11 months ago by sadrul

Modified:
8 years, 11 months ago

Reviewers:
Victoria

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, darin-cc_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 118546 because it caused PrerenderHTML5VideoNetwork to timeout on windows and linux """ Fire canplaythrough as soon as download defers to fix autoplay Reenables delayed firing of canplaythrough for media elements, and fixes the bug that had been introduced where a video with autoplay=true sometimes never starts. With this change, a video with autoplay=true should always (though not necessarily immediately) start playback on its own. BUG=106480, 73609 TEST=media_unitests, manually checking video files in various conditions Review URL: https://chromiumcodereview.appspot.com/9113023 TBR=vrk@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118590

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+136 lines, -210 lines)			Patch
M	media/base/download_rate_monitor.h	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	media/base/download_rate_monitor.cc	View	6 chunks	+18 lines, -13 lines	0 comments	Download
M	media/base/download_rate_monitor_unittest.cc	View	2 chunks	+82 lines, -147 lines	0 comments	Download
M	media/base/pipeline.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	webkit/media/buffered_data_source.cc	View	3 chunks	+12 lines, -7 lines	0 comments	Download
M	webkit/media/buffered_data_source_unittest.cc	View	7 chunks	+7 lines, -31 lines	0 comments	Download
M	webkit/media/webmediaplayer_impl.cc	View	2 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages