Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 9269021: IndexedDB: Start running worker layout tests as ui tests. (Closed)

Created:
8 years, 11 months ago by dgrogan
Modified:
8 years, 10 months ago
Reviewers:
jsbell
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

IndexedDB: Start running worker layout tests as ui tests. BUG=64054 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121169

Patch Set 1 #

Total comments: 3

Patch Set 2 : Added bug link. #

Patch Set 3 : Patch without debug stuff #

Patch Set 4 : sync to ToT #

Patch Set 5 : add new workers test, but it's too big #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M content/browser/in_process_webkit/indexed_db_uitest.cc View 1 2 3 4 3 chunks +22 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jsbell
lgtm, with the comment change noted https://chromiumcodereview.appspot.com/9269021/diff/1/content/browser/in_process_webkit/indexed_db_uitest.cc File content/browser/in_process_webkit/indexed_db_uitest.cc (right): https://chromiumcodereview.appspot.com/9269021/diff/1/content/browser/in_process_webkit/indexed_db_uitest.cc#newcode18 content/browser/in_process_webkit/indexed_db_uitest.cc:18: // "index-basics.html", // ...
8 years, 11 months ago (2012-01-20 22:59:09 UTC) #1
dgrogan
Could you also look at https://bugs.webkit.org/show_bug.cgi?id=76683 ? That has to go in before this chromium ...
8 years, 11 months ago (2012-01-20 23:43:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/9269021/5001
8 years, 10 months ago (2012-02-04 02:05:56 UTC) #3
commit-bot: I haz the power
Try job failure for 9269021-5001 (retry) on mac_rel for step "net_unittests". It's a second try, ...
8 years, 10 months ago (2012-02-04 03:52:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/9269021/11001
8 years, 10 months ago (2012-02-09 00:30:33 UTC) #5
commit-bot: I haz the power
8 years, 10 months ago (2012-02-09 03:43:01 UTC) #6
Change committed as 121169

Powered by Google App Engine
This is Rietveld 408576698