Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 926843003: Move canvas->surface association to the device subclasses (Closed)

Created:
5 years, 10 months ago by Kimmo Kinnunen
Modified:
5 years, 10 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@skimage-filters-03-sksurface-set-root-device-simple
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move canvas->surface association to the device subclasses Move canvas->surface association to the device subclasses. This makes it easier to implement SkImage snapshot features in the device subclasses. Later on SkBaseDevice::newImageSnapshot() could be added and Skia internal code could use that to access images of devices. The SkImage* SkRasterDevice::newImageSnapshot() in this patch would be an example of the snapshot implementation that implements SkBaseDevice::newImageSnapshot(). WIP: WritePixelsTest.cpp:473, probably due to doing COW when the copied bitmap device is accessed for read. (COW dispatched from SkBaseDevice::onBitmapAccess override). BUG=skia:3388

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -112 lines) Patch
M include/core/SkBitmapDevice.h View 2 chunks +7 lines, -1 line 0 comments Download
M include/core/SkCanvas.h View 4 chunks +6 lines, -16 lines 0 comments Download
M include/core/SkDevice.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/core/SkBitmapDevice.cpp View 3 chunks +14 lines, -6 lines 0 comments Download
M src/core/SkCanvas.cpp View 5 chunks +2 lines, -15 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 5 chunks +9 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 6 chunks +35 lines, -7 lines 0 comments Download
M src/image/SkSurface.cpp View 3 chunks +0 lines, -8 lines 0 comments Download
M src/image/SkSurface_Base.h View 2 chunks +2 lines, -7 lines 0 comments Download
M src/image/SkSurface_Gpu.cpp View 3 chunks +4 lines, -17 lines 0 comments Download
M src/image/SkSurface_Raster.cpp View 6 chunks +122 lines, -30 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Kimmo Kinnunen
5 years, 10 months ago (2015-02-19 14:51:34 UTC) #1

Powered by Google App Engine
This is Rietveld 408576698