Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2567)

Unified Diff: chrome/android/java/strings/android_chrome_strings.grd

Issue 926593006: [App banners] Update accessibility strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: formatting Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/strings/android_chrome_strings.grd
diff --git a/chrome/android/java/strings/android_chrome_strings.grd b/chrome/android/java/strings/android_chrome_strings.grd
index 3d18778f74200915bedbd53cf18e6eec35be38ed..dbcb73f8fbc3e476eaf5306ca7a511afb8e3e419 100644
--- a/chrome/android/java/strings/android_chrome_strings.grd
+++ b/chrome/android/java/strings/android_chrome_strings.grd
@@ -898,14 +898,15 @@ You are signing in with a managed account and giving its administrator control o
</message>
<!-- App banner accessibility strings, used for touch exploration -->
- <message name="IDS_APP_BANNER_VIEW_WEB_APP_ACCESSIBILITY" desc="Accessibililty text: Describes the banner content, including the app name and its URL.">
- Prompt to add page to the homescreen. App name: <ph name="APP_NAME">%1$s<ex>Gmail</ex></ph>. App URL: <ph name="APP_URL">%2$s<ex>http://gmail.com</ex></ph>.
+ <message name="IDS_APP_BANNER_VIEW_NATIVE_APP_ACCESSIBILITY" desc="Accessibililty text: Describes a prompt promoting the installation of an app related to the current page, including the app's name and its rating.">
+ View the app on the Google Play Store. App name: <ph name="APP_NAME">%1$s<ex>Gmail</ex></ph>. Average app rating: <ph name="APP_RATING">%2$.1f<ex>4.2</ex></ph>.
dmazzoni 2015/02/19 00:56:32 Concise is good! How about: View app <ph name="AP
gone 2015/02/19 03:01:37 Done.
</message>
- <message name="IDS_APP_BANNER_VIEW_NATIVE_APP_ACCESSIBILITY" desc="Accessibililty text: Describes the banner content, including the app name and rating.">
- Prompt to get app from the Google Play Store. App name: <ph name="APP_NAME">%1$s<ex>Gmail</ex></ph>. App average rating: <ph name="APP_RATING">%2$.1f<ex>4.2</ex></ph>.
+ <message name="IDS_APP_BANNER_VIEW_NATIVE_APP_INSTALL_ACCESSIBILITY" desc="Accessibility text: Indicates that clicking on the button will either purchase the app or install it.">
+ Get the app from the Google Play Store: <ph name="APP_ACTION">%s<ex>Install</ex></ph>
dmazzoni 2015/02/19 00:56:32 The action at the end seems confusing. Why not hav
gone 2015/02/19 00:58:37 The problem is that the Play Store API doesn't let
dmazzoni 2015/02/19 16:50:17 Understood. What you have may be the best you can
</message>
- <message name="IDS_APP_BANNER_INSTALL_ACCESSIBILITY" desc="Accessibility text: Indicates that clicking on the button will purchase the app or install it.">
- Get app from the Google Play Store: <ph name="APP_ACTION">%s<ex>Install</ex></ph>
+
+ <message name="IDS_APP_BANNER_VIEW_WEB_APP_ACCESSIBILITY" desc="Accessibililty text: Details the web app being promoted by the current page, including the app name and its URL.">
+ Web app. App name: <ph name="APP_NAME">%1$s<ex>Gmail</ex></ph>. App URL: <ph name="APP_URL">%2$s<ex>google.com</ex></ph>
dmazzoni 2015/02/19 00:56:32 I think it'd be just as clear to have something li
gone 2015/02/19 03:01:37 Done.
</message>
<!-- DOM Distiller strings -->
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698