[App banners] Update accessibility strings

[App banners] Update accessibility strings

Icon and rating view were missing accessibility strings.

BUG=453170
Committed: https://crrev.com/8fdcfff7f5859b116c834d35fe0737ff595357d5
Cr-Commit-Position: refs/heads/master@{#317093}

[gone, 2015-02-13 23:01:25]

dfalcantara@chromium.org changed reviewers:
+ aurimas@chromium.org

[gone, 2015-02-13 23:01:41]

dfalcantara@chromium.org changed reviewers:
+ newt@chromium.org

[aurimas (slooooooooow), 2015-02-13 23:06:54]

https://codereview.chromium.org/926593006/diff/1/chrome/android/java/strings/...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/926593006/diff/1/chrome/android/java/strings/...
chrome/android/java/strings/android_chrome_strings.grd:832: <message
name="IDS_APP_BANNER_VIEW_ICON_ACCESSIBILITY" desc="Accessibililty text:
Indicates that the user is hovering over the app icon.">
Please expand about what icon you are talking about. It will not be clear to the
translator. Maybe say "...hovering over the application icon in a promotion to
install an application" or something like that.

https://codereview.chromium.org/926593006/diff/1/chrome/android/java/strings/...
chrome/android/java/strings/android_chrome_strings.grd:844: <message
name="IDS_APP_BANNER_VIEW_NATIVE_APP_RATING_ACCESSIBILITY" desc="Accessibililty
text: Describes the banner content, including the app name and rating.">
Elaborate on what banner you are talking about, it will not be clear to the
translators what this is as it is not served together with other strings.

[gone, 2015-02-13 23:29:47]

How are the new ones?

[newt (away), 2015-02-13 23:49:59]

These strings seem overly verbose.

I think we this would work fine: have a custom content description for the app
name TextView that gives an overview of the infobar ("Install app from the
Google Play Store. App name: Gmail."). Then let all the other views have basic
accessibility text: "Rating 4.2 out of 5" and "Install". The images don't need
any content description IMO and should be marked as not important for
accessibility (setImportantForAccessibility()).

https://codereview.chromium.org/926593006/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java
(right):

https://codereview.chromium.org/926593006/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java:103:
mIconView.setContentDescription(context.getString(
Don't use a content description for the icon. It's just noise for users.

https://codereview.chromium.org/926593006/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java:150:
accessibilityText =
funky wrapping. I'd make this two lines

https://codereview.chromium.org/926593006/diff/20001/chrome/android/java/stri...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/926593006/diff/20001/chrome/android/java/stri...
chrome/android/java/strings/android_chrome_strings.grd:833: Prompt to get app
from the Google Play Store.  App name: <ph
name="APP_NAME">%1$s<ex>Gmail</ex></ph>.  App average rating: <ph
name="APP_RATING">%2$.1f<ex>4.2</ex></ph>.
This reads oddly to me. How about: "Install app from the Google Play Store. App
name: Gmail. Rating: 4.2 out of 5."

https://codereview.chromium.org/926593006/diff/20001/chrome/android/java/stri...
chrome/android/java/strings/android_chrome_strings.grd:838: <message
name="IDS_APP_BANNER_VIEW_NATIVE_APP_INSTALL_ACCESSIBILITY" desc="Accessibility
text: Indicates that clicking on the button will purchase the app or install
it.">
I don't think the button needs a content description. "Install" is quite clear.

https://codereview.chromium.org/926593006/diff/20001/chrome/android/java/stri...
chrome/android/java/strings/android_chrome_strings.grd:842: App average rating:
<ph name="APP_RATING">%1$.1f<ex>4.2</ex></ph>.
I'd remove "average" and maybe "app" too. It might be nice to add "out of 5"

https://codereview.chromium.org/926593006/diff/20001/chrome/android/java/stri...
chrome/android/java/strings/android_chrome_strings.grd:846: Prompt to add a
promoted page to the homescreen.  App name: <ph
name="APP_NAME">%1$s<ex>Gmail</ex></ph>.
"Add web app to homescreen. App name: Gmail"

[gone, 2015-02-13 23:52:09]

https://codereview.chromium.org/926593006/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java
(right):

https://codereview.chromium.org/926593006/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java:103:
mIconView.setContentDescription(context.getString(
On 2015/02/13 23:49:58, newt wrote:
> Don't use a content description for the icon. It's just noise for users.

It's not noise if you can click on it.  Clicking  on the icon and the message
are the only ways to go to the app store.

https://codereview.chromium.org/926593006/diff/20001/chrome/android/java/stri...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/926593006/diff/20001/chrome/android/java/stri...
chrome/android/java/strings/android_chrome_strings.grd:833: Prompt to get app
from the Google Play Store.  App name: <ph
name="APP_NAME">%1$s<ex>Gmail</ex></ph>.  App average rating: <ph
name="APP_RATING">%2$.1f<ex>4.2</ex></ph>.
On 2015/02/13 23:49:59, newt wrote:
> This reads oddly to me. How about: "Install app from the Google Play Store.
App
> name: Gmail. Rating: 4.2 out of 5."

Sometimes it costs money.

https://codereview.chromium.org/926593006/diff/20001/chrome/android/java/stri...
chrome/android/java/strings/android_chrome_strings.grd:838: <message
name="IDS_APP_BANNER_VIEW_NATIVE_APP_INSTALL_ACCESSIBILITY" desc="Accessibility
text: Indicates that clicking on the button will purchase the app or install
it.">
On 2015/02/13 23:49:58, newt wrote:
> I don't think the button needs a content description. "Install" is quite
clear.

Sometimes it's a currency amount.

[gone, 2015-02-13 23:55:01]

BTW I'm not sure when the button stopped repeating custom accessibility text but
it's not doing so for me now.  Used to.

[gone, 2015-02-13 23:57:13]

https://codereview.chromium.org/926593006/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java
(right):

https://codereview.chromium.org/926593006/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java:150:
accessibilityText =
On 2015/02/13 23:49:58, newt wrote:
> funky wrapping. I'd make this two lines

Done.

https://codereview.chromium.org/926593006/diff/20001/chrome/android/java/stri...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/926593006/diff/20001/chrome/android/java/stri...
chrome/android/java/strings/android_chrome_strings.grd:833: Prompt to get app
from the Google Play Store.  App name: <ph
name="APP_NAME">%1$s<ex>Gmail</ex></ph>.  App average rating: <ph
name="APP_RATING">%2$.1f<ex>4.2</ex></ph>.
On 2015/02/13 23:52:09, dfalcantara wrote:
> On 2015/02/13 23:49:59, newt wrote:
> > This reads oddly to me. How about: "Install app from the Google Play Store.
> App
> > name: Gmail. Rating: 4.2 out of 5."
> 
> Sometimes it costs money.

That and this message is used for the whole banner.  Clicking on it does
nothing.

[newt (away), 2015-02-14 00:00:19]

https://codereview.chromium.org/926593006/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java
(right):

https://codereview.chromium.org/926593006/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java:103:
mIconView.setContentDescription(context.getString(
On 2015/02/13 23:52:09, dfalcantara wrote:
> On 2015/02/13 23:49:58, newt wrote:
> > Don't use a content description for the icon. It's just noise for users.
> 
> It's not noise if you can click on it.  Clicking  on the icon and the message
> are the only ways to go to the app store.

The user can also click on the TextView. How about adding something to the
TextView's content description about "click to view app in Play Store", then
hiding the button from accessibility.

https://codereview.chromium.org/926593006/diff/20001/chrome/android/java/stri...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/926593006/diff/20001/chrome/android/java/stri...
chrome/android/java/strings/android_chrome_strings.grd:838: <message
name="IDS_APP_BANNER_VIEW_NATIVE_APP_INSTALL_ACCESSIBILITY" desc="Accessibility
text: Indicates that clicking on the button will purchase the app or install
it.">
On 2015/02/13 23:52:09, dfalcantara wrote:
> On 2015/02/13 23:49:58, newt wrote:
> > I don't think the button needs a content description. "Install" is quite
> clear.
> 
> Sometimes it's a currency amount.

True. But what does a sighted user see? "$0.99" or "Install". Why should we
provide extra/different information to TalkBack users?

Also, I'm imagining a TalkBack user exploring the views in this infobar and
hearing "Prompt to get app from the Google Play Store. App name: Gmail. App
average rating: 4.2. Click to open the Play Storage page for the app: Gmail. App
average rating: 4.2. Get the app from the Google Play Store: Install." It's
quite wordy.

[newt (away), 2015-02-14 00:00:55]

https://codereview.chromium.org/926593006/diff/20001/chrome/android/java/src/...
>
chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java:103:
> mIconView.setContentDescription(context.getString(
> On 2015/02/13 23:52:09, dfalcantara wrote:
> > On 2015/02/13 23:49:58, newt wrote:
> > > Don't use a content description for the icon. It's just noise for users.
> > 
> > It's not noise if you can click on it.  Clicking  on the icon and the
message
> > are the only ways to go to the app store.
> 
> The user can also click on the TextView. How about adding something to the
> TextView's content description about "click to view app in Play Store", then
> hiding the button from accessibility.

*hiding the icon from accessibility

[gone, 2015-02-14 00:01:45]

Pinging dmazzonni@ about it so we don't bikeshed over the strings.

[gone, 2015-02-17 23:46:26]

dfalcantara@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[gone, 2015-02-17 23:46:26]

+dmazzoni for the string changes

[dmazzoni, 2015-02-19 00:56:32]

Screen reader users tend to like things to be as concise as possible without
being unclear.

I've made some suggestions, but feel free to make the final decision based on
your best judgement. Everything you've presented is accessible, it's just a
question of polishing now.

https://chromiumcodereview.appspot.com/926593006/diff/60001/chrome/android/ja...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://chromiumcodereview.appspot.com/926593006/diff/60001/chrome/android/ja...
chrome/android/java/strings/android_chrome_strings.grd:902: View the app on the
Google Play Store.  App name: <ph name="APP_NAME">%1$s<ex>Gmail</ex></ph>. 
Average app rating: <ph name="APP_RATING">%2$.1f<ex>4.2</ex></ph>.
Concise is good! How about:

View app <ph name="APP_NAME">%1$s<ex>Gmail</ex></ph> on the Play Store. Rating:
<ph name="APP_RATING">%2$.1f<ex>4.2</ex></ph>.

https://chromiumcodereview.appspot.com/926593006/diff/60001/chrome/android/ja...
chrome/android/java/strings/android_chrome_strings.grd:905: Get the app from the
Google Play Store: <ph name="APP_ACTION">%s<ex>Install</ex></ph>
The action at the end seems confusing. Why not have two strings:

Purchase the app from the Google Play Store for [$1.99}
or
Install the free app from the Google Play Store

https://chromiumcodereview.appspot.com/926593006/diff/60001/chrome/android/ja...
chrome/android/java/strings/android_chrome_strings.grd:909: Web app.  App name:
<ph name="APP_NAME">%1$s<ex>Gmail</ex></ph>.  App URL: <ph
name="APP_URL">%2$s<ex>google.com</ex></ph>
I think it'd be just as clear to have something like "Gmail, web app.
google.com"

<ph name="APP_NAME">%1$s<ex>Gmail</ex></ph>, web app. <ph
name="APP_URL">%2$s<ex>google.com</ex></ph>

[gone, 2015-02-19 00:58:37]

https://chromiumcodereview.appspot.com/926593006/diff/60001/chrome/android/ja...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://chromiumcodereview.appspot.com/926593006/diff/60001/chrome/android/ja...
chrome/android/java/strings/android_chrome_strings.grd:905: Get the app from the
Google Play Store: <ph name="APP_ACTION">%s<ex>Install</ex></ph>
On 2015/02/19 00:56:32, dmazzoni wrote:
> The action at the end seems confusing. Why not have two strings:
> 
> Purchase the app from the Google Play Store for [$1.99}
> or
> Install the free app from the Google Play Store

The problem is that the Play Store API doesn't let us know if the app is free or
not; we only get back the text to put on the button (INSTALL or $amount).  Ideas
on what to do in that situation?

[gone, 2015-02-19 03:01:37]

https://chromiumcodereview.appspot.com/926593006/diff/60001/chrome/android/ja...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://chromiumcodereview.appspot.com/926593006/diff/60001/chrome/android/ja...
chrome/android/java/strings/android_chrome_strings.grd:902: View the app on the
Google Play Store.  App name: <ph name="APP_NAME">%1$s<ex>Gmail</ex></ph>. 
Average app rating: <ph name="APP_RATING">%2$.1f<ex>4.2</ex></ph>.
On 2015/02/19 00:56:32, dmazzoni wrote:
> Concise is good! How about:
> 
> View app <ph name="APP_NAME">%1$s<ex>Gmail</ex></ph> on the Play Store.
Rating:
> <ph name="APP_RATING">%2$.1f<ex>4.2</ex></ph>.

Done.

https://chromiumcodereview.appspot.com/926593006/diff/60001/chrome/android/ja...
chrome/android/java/strings/android_chrome_strings.grd:909: Web app.  App name:
<ph name="APP_NAME">%1$s<ex>Gmail</ex></ph>.  App URL: <ph
name="APP_URL">%2$s<ex>google.com</ex></ph>
On 2015/02/19 00:56:32, dmazzoni wrote:
> I think it'd be just as clear to have something like "Gmail, web app.
> google.com"
> 
> <ph name="APP_NAME">%1$s<ex>Gmail</ex></ph>, web app. <ph
> name="APP_URL">%2$s<ex>google.com</ex></ph>

Done.

[dmazzoni, 2015-02-19 16:50:17]

lgtm

https://chromiumcodereview.appspot.com/926593006/diff/60001/chrome/android/ja...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://chromiumcodereview.appspot.com/926593006/diff/60001/chrome/android/ja...
chrome/android/java/strings/android_chrome_strings.grd:905: Get the app from the
Google Play Store: <ph name="APP_ACTION">%s<ex>Install</ex></ph>
On 2015/02/19 00:58:37, dfalcantara wrote:
> On 2015/02/19 00:56:32, dmazzoni wrote:
> > The action at the end seems confusing. Why not have two strings:
> > 
> > Purchase the app from the Google Play Store for [$1.99}
> > or
> > Install the free app from the Google Play Store
> 
> The problem is that the Play Store API doesn't let us know if the app is free
or
> not; we only get back the text to put on the button (INSTALL or $amount). 
Ideas
> on what to do in that situation?

Understood. What you have may be the best you can do, then. Thanks.

[gone, 2015-02-19 17:49:08]

Great, thanks!  Newt, any other concerns about this CL, or is it alright to land
with these approved strings?

[newt (away), 2015-02-19 18:45:21]

lgtm

[gone, 2015-02-19 18:47:50]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2015-02-19 18:48:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/926593006/80001

[commit-bot: I haz the power, 2015-02-19 19:15:30]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-02-19 19:16:13]

Patchset 5 (id:??) landed as
https://crrev.com/8fdcfff7f5859b116c834d35fe0737ff595357d5
Cr-Commit-Position: refs/heads/master@{#317093}