Improve compile times for swarm application startup

vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
 #include "vm/bootstrap.h"
@@ skipping 15 matching lines @@
 #include "vm/runtime_entry.h"
 #include "vm/scopes.h"
 #include "vm/timer.h"
 #include "vm/unicode.h"
 
 namespace dart {
 
 DEFINE_FLAG(bool, generate_gdb_symbols, false,
     "Generate symbols of generated dart functions for debugging with GDB");
 
+static const char* kGetterPrefix = "get:";
+static const intptr_t kGetterPrefixLength = strlen(kGetterPrefix);
+static const char* kSetterPrefix = "set:";
+static const intptr_t kSetterPrefixLength = strlen(kSetterPrefix);
+
 cpp_vtable Object::handle_vtable_ = 0;
 cpp_vtable Smi::handle_vtable_ = 0;
 
 // These are initialized to a value that will force a illegal memory access if
 // they are being used.
 #if defined(RAW_NULL)
 #error RAW_NULL should not be defined.
 #endif
 #define RAW_NULL kHeapObjectTag
 RawObject* Object::null_ = reinterpret_cast<RawInstance*>(RAW_NULL);
@@ skipping 1463 matching lines @@
 RawFunction* Class::LookupFactory(const String& name) const {
   Function& function = Function::Handle(LookupFunction(name));
   if (function.IsNull() || !function.IsFactory()) {
     return Function::null();
   }
   ASSERT(function.is_static());
   return function.raw();
 }
 
 
+static bool MatchesAccessorName(const String& name,
+                                const char* prefix,
+                                intptr_t prefix_length,
+                                const String& accessor_name) {
+  intptr_t name_len = name.Length();
+  intptr_t accessor_name_len = accessor_name.Length();
+
+  if (name_len != (accessor_name_len + prefix_length)) {
+    return false;
+  }
+  for (intptr_t i = 0; i < prefix_length; i++) {
+    if (name.CharAt(i) != prefix[i]) {
+      return false;
+    }
+  }
+  for (intptr_t i = 0, j = prefix_length; i < accessor_name_len; i++, j++) {
+    if (name.CharAt(j) != accessor_name.CharAt(i)) {
+      return false;
+    }
+  }
+  return true;
+}
+
+
 static bool MatchesPrivateName(const String& name, const String& private_name) {
   intptr_t name_len = name.Length();
   intptr_t private_len = private_name.Length();
   // The private_name must at least have room for the separator and one key
   // character.
   if ((name_len < (private_len + 2)) || (name_len == 0) || (private_len == 0)) {
     return false;
   }
 
   // Check for the private key separator.
@@ skipping 22 matching lines @@
     if (function_name.Equals(name) || MatchesPrivateName(function_name, name)) {
       return function.raw();
     }
   }
 
   // No function found.
   return Function::null();
 }
 
 
+RawFunction* Class::LookupGetterFunction(const String& name) const {
+  return LookupAccessorFunction(kGetterPrefix, kGetterPrefixLength, name);
+}
+
+
+RawFunction* Class::LookupSetterFunction(const String& name) const {
+  return LookupAccessorFunction(kSetterPrefix, kSetterPrefixLength, name);
+}
+
+
+RawFunction* Class::LookupAccessorFunction(const char* prefix,
+                                           intptr_t prefix_length,
+                                           const String& name) const {
+  Isolate* isolate = Isolate::Current();
+  Array& funcs = Array::Handle(isolate, functions());
+  Function& function = Function::Handle(isolate, Function::null());
+  String& function_name = String::Handle(isolate, String::null());
+  intptr_t len = funcs.Length();
+  for (intptr_t i = 0; i < len; i++) {
+    function ^= funcs.At(i);
+    function_name ^= function.name();
+    if (MatchesAccessorName(function_name, prefix, prefix_length, name)) {
+      return function.raw();
+    }
+  }
+
+  // No function found.
+  return Function::null();
+}
+
+
 RawFunction* Class::LookupFunctionAtToken(intptr_t token_index) const {
   // TODO(hausner): we can shortcut the negative case if we knew the
   // beginning and end token position of the class.
   Array& funcs = Array::Handle(functions());
   Function& func = Function::Handle();
   intptr_t len = funcs.Length();
   for (intptr_t i = 0; i < len; i++) {
     func ^= funcs.At(i);
     if ((func.token_index() <= token_index) &&
         (token_index < func.end_token_index())) {
@@ skipping 1916 matching lines @@
   intptr_t len = OS::SNPrint(NULL, 0, kFormat, function_name, f0, f1, f2) + 1;
   char* chars = reinterpret_cast<char*>(
       Isolate::Current()->current_zone()->Allocate(len));
   OS::SNPrint(chars, len, kFormat, function_name, f0, f1, f2);
   return chars;
 }
 
 
 RawString* Field::GetterName(const String& field_name) {
   String& str = String::Handle();
-  str = String::New("get:");
+  str = String::New(kGetterPrefix);
   str = String::Concat(str, field_name);
+  return str.raw();
+}
+
+
+RawString* Field::GetterSymbol(const String& field_name) {
+  String& str = String::Handle();
+  str = Field::GetterName(field_name);
   return String::NewSymbol(str);
 }
 
 
 RawString* Field::SetterName(const String& field_name) {
   String& str = String::Handle();
-  str = String::New("set:");
+  str = String::New(kSetterPrefix);
   str = String::Concat(str, field_name);
+  return str.raw();
+}
+
+
+RawString* Field::SetterSymbol(const String& field_name) {
+  String& str = String::Handle();
+  str = Field::SetterName(field_name);
   return String::NewSymbol(str);
 }
 
 
 RawString* Field::NameFromGetter(const String& getter_name) {
   String& str = String::Handle();
-  str = String::New("get:");
+  str = String::New(kGetterPrefix);
   str = String::SubString(getter_name, str.Length());
-  return String::NewSymbol(str);
+  return str.raw();
 }
 
 
 RawString* Field::NameFromSetter(const String& setter_name) {
   String& str = String::Handle();
-  str = String::New("set:");
+  str = String::New(kSetterPrefix);
   str = String::SubString(setter_name, str.Length());
-  return String::NewSymbol(str);
+  return str.raw();
 }
 
 
 void Field::set_name(const String& value) const {
   ASSERT(value.IsSymbol());
   StorePointer(&raw_ptr()->name_, value.raw());
 }
 
 
 RawInstance* Field::value() const {
@@ skipping 3065 matching lines @@
 
 
 template<typename T>
 RawString* String::NewSymbol(const T* characters, intptr_t len) {
   Isolate* isolate = Isolate::Current();
 
   // Calculate the String hash for this sequence of characters.
   intptr_t hash = Hash(characters, len);
 
   const Array& symbol_table =
-      Array::Handle(isolate->object_store()->symbol_table());
+      Array::Handle(isolate, isolate->object_store()->symbol_table());
   // Last element of the array is the number of used elements.
   intptr_t table_size = symbol_table.Length() - 1;
   intptr_t index = hash % table_size;
 
-  String& symbol = String::Handle();
+  String& symbol = String::Handle(isolate, String::null());
   symbol ^= symbol_table.At(index);
   while (!symbol.IsNull() && !symbol.Equals(characters, len)) {
     index = (index + 1) % table_size;  // Move to next element.
     symbol ^= symbol_table.At(index);
   }
   // Since we leave enough room in the table to guarantee, that we find an
   // empty spot, index is the insertion point if symbol is null.
   if (symbol.IsNull()) {
     // Allocate new result string.
     symbol = String::New(characters, len, Heap::kOld);
@@ skipping 1086 matching lines @@
   const String& str = String::Handle(pattern());
   const char* format = "JSRegExp: pattern=%s flags=%s";
   intptr_t len = OS::SNPrint(NULL, 0, format, str.ToCString(), Flags());
   char* chars = reinterpret_cast<char*>(
       Isolate::Current()->current_zone()->Allocate(len + 1));
   OS::SNPrint(chars, (len + 1), format, str.ToCString(), Flags());
   return chars;
 }
 
 }  // namespace dart