Issue 9265019: Add install-build-deps.py to patch msbuild for vs2010

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9265019: Add install-build-deps.py to patch msbuild for vs2010 (Closed)

Created:
8 years, 11 months ago by scottmg

Modified:
8 years, 11 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews

Visibility:
Public.

More Reviews

Description

Add install-build-deps.py to patch msbuild for vs2010 (patch discussed in bug and on connect page) BUG=97534 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118381

Patch Set 4 : fixes #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -0 lines)			Patch
	A	build/win/install-build-deps.py	View	1 2 3	1 chunk	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm, thanks https://chromiumcodereview.appspot.com/9265019/diff/2001/build/win/install-build-deps.py File build/win/install-build-deps.py (right): https://chromiumcodereview.appspot.com/9265019/diff/2001/build/win/install-build-deps.py#newcode21 build/win/install-build-deps.py:21: shutil.copyfile(source_path, backup_path) What about: print "Backing up ...

8 years, 11 months ago (2012-01-19 21:52:01 UTC) #2

scottmg

8 years, 11 months ago (2012-01-19 21:57:26 UTC) #3

https://chromiumcodereview.appspot.com/9265019/diff/2001/build/win/install-bu...
File build/win/install-build-deps.py (right):

https://chromiumcodereview.appspot.com/9265019/diff/2001/build/win/install-bu...
build/win/install-build-deps.py:21: shutil.copyfile(source_path, backup_path)
On 2012/01/19 21:52:01, Marc-Antoine Ruel wrote:
> What about:
> print "Backing up %s" % source_path

Done.

Expand Messages | Collapse Messages

Issue 9265019: Add install-build-deps.py to patch msbuild for vs2010 (Closed)

Description

Patch Set 1 #

Patch Set 2 : formatting #

Patch Set 3 : fixes #

Patch Set 4 : fixes #

Messages