Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 9265007: MIPS: Make sure transitioned arrays efficiently call builtin Array functions (Closed)

Created:
8 years, 11 months ago by kalmard
Modified:
8 years, 11 months ago
Reviewers:
kisg, Paul Lind, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Make sure transitioned arrays efficiently call builtin Array functions Port r10356 (69da81). Original commit message: Loosen the requirement for Map equivalency on several map checks, including checks up the prototype chain, that are not sensitive to ElementsKinds. These selected map checks should also match against FAST_DOUBLE_ELEMENT and FAST_ELEMENT transitions of the original map. This specifically helps all variants of transitioned JSArrays to still efficiently call builtins like push, pop and sort. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10461

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -52 lines) Patch
M src/mips/lithium-codegen-mips.h View 3 chunks +6 lines, -3 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 3 chunks +21 lines, -15 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 2 chunks +20 lines, -6 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 2 chunks +39 lines, -5 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 6 chunks +12 lines, -23 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kalmard
Successful testing of v8 on MIPS requires the following patches to be landed as well: ...
8 years, 11 months ago (2012-01-19 12:31:16 UTC) #1
danno
8 years, 11 months ago (2012-01-19 13:57:11 UTC) #2
lgtm

LGTM, landing

Powered by Google App Engine
This is Rietveld 408576698