src/x64/lithium-codegen-x64.cc - Issue 9265003: Ensure that LRandom preserves rsi after call to the C function on x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.cc

Issue 9265003: Ensure that LRandom preserves rsi after call to the C function on x64. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/lithium-codegen-x64.cc

diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc

index 291901e537e334256481a26b9d354566be30f408..350ff6f4d79079d02aba812a64eb5afe5e0e175d 100644

--- a/src/x64/lithium-codegen-x64.cc

+++ b/src/x64/lithium-codegen-x64.cc

@@ -2962,6 +2962,7 @@ void LCodeGen::DoRandom(LRandom* instr) {

__ movq(global_object,

FieldOperand(global_object, GlobalObject::kGlobalContextOffset));

__ CallCFunction(ExternalReference::random_uint32_function(isolate()), 1);

+ __ movq(rsi, Operand(rbp, StandardFrameConstants::kContextOffset));

// Convert 32 random bits in rax to 0.(32 random bits) in a double

// by computing:

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-110509.js » ('j') | no next file with comments »