Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 9264071: Add per-tab XSSAuditorEnabled setting. (Closed)

Created:
8 years, 10 months ago by mnaganov (inactive)
Modified:
8 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Add per-tab XSSAuditorEnabled setting. There is no corresponding "global" setting, only a command-line flag. BUG=105537 TBR=pkasting Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120115

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 4 chunks +9 lines, -1 line 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/glue/webpreferences.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
mnaganov (inactive)
Hi Mattias, A small and easy change to help us moving forward.
8 years, 10 months ago (2012-01-31 15:58:04 UTC) #1
mnaganov (inactive)
+Bernhard
8 years, 10 months ago (2012-02-01 10:30:50 UTC) #2
Bernhard Bauer
LGTM.
8 years, 10 months ago (2012-02-01 10:36:47 UTC) #3
mnaganov (inactive)
+Darin for webkit/glue/webpreferences.cc I've changed the default value of xss_auditor_enabled to 'true'. It's anyway enabled ...
8 years, 10 months ago (2012-02-01 12:08:19 UTC) #4
darin (slow to review)
LGTM
8 years, 10 months ago (2012-02-01 18:04:43 UTC) #5
mnaganov_google.com
Peter, I suppose you will not object against this change, I had a similar one ...
8 years, 10 months ago (2012-02-01 22:28:42 UTC) #6
Peter Kasting
8 years, 10 months ago (2012-02-03 23:12:39 UTC) #7
Rubber-stamp OWNERS LGTM

Powered by Google App Engine
This is Rietveld 408576698