Issue 9264059: Enable hide animation for login screen.

Issue 9264059: Enable hide animation for login screen. (Closed)

Created:
8 years, 10 months ago by oshima

Modified:
8 years, 10 months ago

Reviewers:
Nikita (slow), Ben Goodger (Google)

CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, ben+watch_chromium.org, Daniel Erat

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable hide animation for login screen. Close login window after a browser is opened. This is necessary because browser has nested loop which wait for session data. Don't apply sho/hide animation to lock screen. This depends on http://codereview.chromium.org/9233044/ and I will run bots after it is landed. BUG=none TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120046

Patch Set 1 #

Patch Set 2 : . #

Total comments: 6

Patch Set 3 : addressed comments #

Patch Set 4 : sync #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -15 lines)			Patch
M	ash/shell.cc	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/base_login_display_host.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/base_login_display_host.cc	View	1 2	3 chunks	+19 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/existing_user_controller_browsertest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/lock_window_aura.cc	View	1 2 3	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_display_host.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_utils.cc	View	1 2 3	1 chunk	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/login/webui_login_display_host.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/webui_login_display_host.cc	View	1 2 3	6 chunks	+17 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

lgtm http://codereview.chromium.org/9264059/diff/4001/chrome/browser/chromeos/login/base_login_display_host.cc File chrome/browser/chromeos/login/base_login_display_host.cc (right): http://codereview.chromium.org/9264059/diff/4001/chrome/browser/chromeos/login/base_login_display_host.cc#newcode143 chrome/browser/chromeos/login/base_login_display_host.cc:143: // NOTIFICATION_BROWSER_OPENED is issued after browser is creaetd, ...

8 years, 10 months ago (2012-01-31 15:26:24 UTC) #2

oshima

http://codereview.chromium.org/9264059/diff/4001/chrome/browser/chromeos/login/base_login_display_host.cc File chrome/browser/chromeos/login/base_login_display_host.cc (right): http://codereview.chromium.org/9264059/diff/4001/chrome/browser/chromeos/login/base_login_display_host.cc#newcode143 chrome/browser/chromeos/login/base_login_display_host.cc:143: // NOTIFICATION_BROWSER_OPENED is issued after browser is creaetd, but ...

8 years, 10 months ago (2012-01-31 17:47:50 UTC) #3

lgtm

Expand Messages | Collapse Messages