Fix for bug 1229: Unary operator plus is not allowed ... except for literals.

runtime/vm/scanner.cc

Index: runtime/vm/scanner.cc
===================================================================
--- runtime/vm/scanner.cc	(revision 3699)
+++ runtime/vm/scanner.cc	(working copy)
@@ -186,6 +186,11 @@
 }
 
 
+static bool IsWhiteSpace(char ch) {

[hausner, 2012/01/31 18:09:46]

This definition of what a whitespace character is differs from the one in the
function below. I find that confusing. I would inline the code in the one place
where it's used below, if you still need it (see comment below).

[srdjan, 2012/01/31 19:26:37]

Discussed the difference offline. Removed the method since we are looking at
IsNumberStart instead.

+  return ch == '\0' || ch == '\n' || ch == '\r' || ch == ' ' || ch == '\t';
+}
+
+
 void Scanner::ConsumeWhiteSpace() {
   while (c0_ == ' ' || c0_ == '\t' || c0_ == '\n') {
     ReadChar();
@@ -593,7 +598,9 @@
         break;
 
       case '+':  // +  ++  +=
-        Recognize(Token::kADD);
+        ReadChar();
+        current_token_.kind =
+            IsWhiteSpace(c0_) ? Token::kADD : Token::kTIGHTADD;

[hausner, 2012/01/31 18:09:46]

Would it not make more sense to reverse the logic here? That is, a + is kADD
unless it is immediately followed by a digit and possibly a dot (+.5) or
whatever the rules for literals allow. In that case, we make it a kTIGHTADD.

[srdjan, 2012/01/31 19:26:37]

Changed.

         if (c0_ == '+') {
           Recognize(Token::kINCR);
         } else if (c0_ == '=') {