Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1363)

Unified Diff: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Issue 9264049: Allow SiteInstance for about:blank in new tab to be reused. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove logging statements. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
index 17826259c81f170f9c3645b0c796be56ddd20f28..687f9b5a14c38996b43fc9146d08094c9d10b7b7 100644
--- a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
+++ b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
@@ -599,7 +599,14 @@ class OmniboxViewTest : public InProcessBrowserTest,
popup_model->result().default_match()->type);
// Open the default match.
- ASSERT_NO_FATAL_FAILURE(SendKey(ui::VKEY_RETURN, 0));
+ {
+ ui_test_utils::WindowedNotificationObserver observer(
Peter Kasting 2012/02/06 18:35:53 Nit: Do we do this anywhere else in this file or o
Charlie Reis 2012/02/06 19:23:00 Good call. Turns out there's already a SendKeyAnd
+ content::NOTIFICATION_NAV_ENTRY_COMMITTED,
+ content::Source<content::NavigationController>(
+ &browser()->GetSelectedWebContents()->GetController()));
+ ASSERT_NO_FATAL_FAILURE(SendKey(ui::VKEY_RETURN, 0));
+ observer.Wait();
+ }
GURL url = browser()->GetSelectedWebContents()->GetURL();
EXPECT_STREQ(kSearchTextURL, url.spec().c_str());
@@ -616,7 +623,14 @@ class OmniboxViewTest : public InProcessBrowserTest,
popup_model->result().default_match()->type);
// Open the default match.
- ASSERT_NO_FATAL_FAILURE(SendKey(ui::VKEY_RETURN, 0));
+ {
+ ui_test_utils::WindowedNotificationObserver observer(
+ content::NOTIFICATION_NAV_ENTRY_COMMITTED,
+ content::Source<content::NavigationController>(
+ &browser()->GetSelectedWebContents()->GetController()));
+ ASSERT_NO_FATAL_FAILURE(SendKey(ui::VKEY_RETURN, 0));
+ observer.Wait();
+ }
url = browser()->GetSelectedWebContents()->GetURL();
EXPECT_STREQ(kSearchSingleCharURL, url.spec().c_str());
}
@@ -1157,12 +1171,7 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewTest, AltEnter) {
AltEnterTest();
}
-// DISABLED http://crbug.com/80118
-#if defined(OS_LINUX)
-IN_PROC_BROWSER_TEST_F(OmniboxViewTest, DISABLED_EnterToSearch) {
-#else
IN_PROC_BROWSER_TEST_F(OmniboxViewTest, EnterToSearch) {
-#endif // OS_LINUX
EnterToSearchTest();
}
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc ('k') | content/browser/tab_contents/tab_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698