Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9264049: Allow SiteInstance for about:blank in new tab to be reused. (Closed)

Created:
8 years, 10 months ago by Charlie Reis
Modified:
8 years, 10 months ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Allow SiteInstance for about:blank in new tab to be reused. Also fix flaky tests from the resulting speedup. BUG=111975 TEST=Open a new tab to about:blank. No process swap for nav to Google. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120621

Patch Set 1 #

Total comments: 1

Patch Set 2 : Name change #

Patch Set 3 : Fix affected test #

Patch Set 4 : Temporary log statements to debug tests. #

Patch Set 5 : Fix EnterToSearch test. #

Patch Set 6 : Remove logging statements. #

Total comments: 2

Patch Set 7 : Use helper function #

Total comments: 2

Patch Set 8 : Fix spacing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -16 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 1 2 4 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 2 3 4 5 6 7 4 chunks +12 lines, -8 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 4 5 1 chunk +6 lines, -2 lines 0 comments Download
M content/browser/tab_contents/tab_contents_unittest.cc View 1 2 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Charlie Reis
8 years, 10 months ago (2012-01-30 21:46:54 UTC) #1
darin (slow to review)
LGTM! https://chromiumcodereview.appspot.com/9264049/diff/1/content/browser/tab_contents/tab_contents_unittest.cc File content/browser/tab_contents/tab_contents_unittest.cc (right): https://chromiumcodereview.appspot.com/9264049/diff/1/content/browser/tab_contents/tab_contents_unittest.cc#newcode998 content/browser/tab_contents/tab_contents_unittest.cc:998: const GURL newUrl("http://www.google.com"); nit: new_url
8 years, 10 months ago (2012-01-30 22:12:37 UTC) #2
Charlie Reis
Hey Darin-- This seemingly-simple CL exposed some test flakiness because it speeds up a lot ...
8 years, 10 months ago (2012-02-04 00:25:34 UTC) #3
darin (slow to review)
makes sense! LGTM
8 years, 10 months ago (2012-02-04 00:27:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/9264049/14003
8 years, 10 months ago (2012-02-06 16:15:21 UTC) #5
commit-bot: I haz the power
Presubmit check for 9264049-14003 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 10 months ago (2012-02-06 16:15:23 UTC) #6
Charlie Reis
Peter, can you take a look at omnibox_view_browsertest.cc for owner's approval?
8 years, 10 months ago (2012-02-06 16:47:04 UTC) #7
Peter Kasting
OWNERS LGTM https://chromiumcodereview.appspot.com/9264049/diff/14003/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc File chrome/browser/ui/omnibox/omnibox_view_browsertest.cc (right): https://chromiumcodereview.appspot.com/9264049/diff/14003/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc#newcode603 chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:603: ui_test_utils::WindowedNotificationObserver observer( Nit: Do we do this ...
8 years, 10 months ago (2012-02-06 18:35:52 UTC) #8
Charlie Reis
https://chromiumcodereview.appspot.com/9264049/diff/14003/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc File chrome/browser/ui/omnibox/omnibox_view_browsertest.cc (right): https://chromiumcodereview.appspot.com/9264049/diff/14003/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc#newcode603 chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:603: ui_test_utils::WindowedNotificationObserver observer( On 2012/02/06 18:35:53, Peter Kasting wrote: > ...
8 years, 10 months ago (2012-02-06 19:23:00 UTC) #9
Peter Kasting
Awesome. LGTM https://chromiumcodereview.appspot.com/9264049/diff/19002/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc File chrome/browser/ui/omnibox/omnibox_view_browsertest.cc (right): https://chromiumcodereview.appspot.com/9264049/diff/19002/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc#newcode570 chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:570: browser(), ui::VKEY_RETURN, ui::EF_CONTROL_DOWN, Nit: You could also ...
8 years, 10 months ago (2012-02-06 19:25:16 UTC) #10
Charlie Reis
https://chromiumcodereview.appspot.com/9264049/diff/19002/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc File chrome/browser/ui/omnibox/omnibox_view_browsertest.cc (right): https://chromiumcodereview.appspot.com/9264049/diff/19002/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc#newcode570 chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:570: browser(), ui::VKEY_RETURN, ui::EF_CONTROL_DOWN, On 2012/02/06 19:25:17, Peter Kasting wrote: ...
8 years, 10 months ago (2012-02-06 19:32:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/9264049/18002
8 years, 10 months ago (2012-02-06 19:34:16 UTC) #12
commit-bot: I haz the power
8 years, 10 months ago (2012-02-06 21:56:55 UTC) #13 
Change committed as 120621

Powered by Google App Engine
This is Rietveld 408576698