Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 9264026: Add support for generating nmfs for pnacl pexes with glibc (vs pnacl nexes). (Closed)

Created:
8 years, 11 months ago by jvoung - send to chromium...
Modified:
8 years, 11 months ago
CC:
native-client-reviews_googlegroups.com, pnacl-team_google.com
Visibility:
Public.

Description

Add support for generating nmfs for pnacl pexes with glibc (vs pnacl nexes). This currently hooks onto the scons stuff where a base nmf file is required. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2546 TEST= run_pnacl_example_browser_test with --nacl_glibc, and it gets past the nmf generation stage.

Patch Set 1 #

Patch Set 2 : Handle runnable-ld.so differently (there is no portable one...) #

Patch Set 3 : move comment #

Patch Set 4 : x #

Total comments: 1

Patch Set 5 : x #

Patch Set 6 : add nmf gen, need to test... #

Patch Set 7 : hook up to scons... #

Patch Set 8 : revert some mo stuff. #

Patch Set 9 : add search path args for psos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -48 lines) Patch
M SConstruct View 1 2 3 4 5 6 7 8 3 chunks +56 lines, -25 lines 0 comments Download
M pnacl/driver/pnacl-meta.py View 1 2 3 4 5 6 3 chunks +13 lines, -9 lines 0 comments Download
A pnacl/driver/pnacl-nmf.py View 1 2 3 4 5 6 1 chunk +175 lines, -0 lines 0 comments Download
M site_scons/site_tools/naclsdk.py View 1 2 3 4 5 6 3 chunks +3 lines, -1 line 0 comments Download
M tests/pnacl_client_translator/pnacl_test_example.html View 1 2 3 4 5 6 7 2 chunks +12 lines, -10 lines 0 comments Download
M tests/pnacl_client_translator/pnacl_test_example.nmf View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jvoung - send to chromium...
ptal. Sample output from scons staging directory with platform=x86-32 bitcode=1 --nacl_glibc: { "program":{ "x86-64":{ "url":"runnable-ld.so"}, ...
8 years, 11 months ago (2012-01-20 18:47:10 UTC) #1
pdox
I would strongly prefer we either: 1) Emit a list of strings from pnacl-meta, and ...
8 years, 11 months ago (2012-01-20 21:48:57 UTC) #2
jvoung - send to chromium...
Went with 2) -- It theoretically traces .pso's for more dependencies until no more are ...
8 years, 11 months ago (2012-01-23 22:31:00 UTC) #3
jvoung - send to chromium...
Hmm can't really make a .pso test case right now, so I think this is ...
8 years, 11 months ago (2012-01-24 00:03:21 UTC) #4
sehr (please use chromium)
On 2012/01/24 00:03:21, jvoung wrote: > Hmm can't really make a .pso test case right ...
8 years, 11 months ago (2012-01-26 16:38:36 UTC) #5
jvoung - send to chromium...
8 years, 11 months ago (2012-01-26 18:24:34 UTC) #6
On 2012/01/26 16:38:36, sehr wrote:
> On 2012/01/24 00:03:21, jvoung wrote:
> > Hmm can't really make a .pso test case right now, so I think this is about
it
> > for now. PTAL.
> > 
> > re: making a .pso test case, see --
> > http://code.google.com/p/nativeclient/issues/detail?id=2556
> > 
> > 
> > 
> > On 2012/01/23 22:31:00, jvoung wrote:
> > > Went with 2) -- It theoretically traces .pso's for more dependencies until
> no
> > > more are found, and does not attempt to trace .so's (we could extend it to
> run
> > > objdump and grep the NEEDED lines of output or something though)...
> > > 
> > > 
> > > 
> > > On 2012/01/20 21:48:57, pdox wrote:
> > > > I would strongly prefer we either:
> > > > 
> > > > 1) Emit a list of strings from pnacl-meta, and parse that list in
> > SConstruct,
> > > > instead of emulating the ldd output format from pnacl-meta.
> > > > 
> > > > -or-
> > > > 
> > > > 2) Add a new script, pnacl-nmf.py, for building nmf files from a pexe.
> Both
> > > > SCons and PNaCl users could use this.
> > > > 
> > > > But I'll defer to other reviewers.
> 
> LGTM.

Ah my git branch somehow got corrupted or something:

fatal: failed to read object ...

Will re-upload.

Powered by Google App Engine
This is Rietveld 408576698