Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 9264025: aura: Replace UI-feature GYP flags with switches. (Closed)

Created:
8 years, 11 months ago by Daniel Erat
Modified:
8 years, 11 months ago
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org, alicet1
Visibility:
Public.

Description

aura: Replace UI-feature GYP flags with switches. This replaces the aura_show_about_flag_window_mode and chromeos_legacy_power_button GYP flags with --aura-force-compact-window-mode and --aura-legacy-power-button command-line switches. There is concern that using compile-time flags to control these features will greatly increase the workload on the Chrome OS builders; we apparently currently share Chrome binaries across all Chrome OS boards with the same architecture. BUG=109209, 109052, chrome-os-partner:7570 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118522

Patch Set 1 #

Patch Set 2 : remove old ifdef #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -85 lines) Patch
M ash/ash_switches.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/ash_switches.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M ash/shell.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ash/wm/power_button_controller.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M ash/wm/power_button_controller.cc View 4 chunks +49 lines, -46 lines 0 comments Download
M ash/wm/power_button_controller_unittest.cc View 10 chunks +11 lines, -3 lines 0 comments Download
M build/common.gypi View 1 2 8 chunks +0 lines, -26 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Daniel Erat
8 years, 11 months ago (2012-01-20 00:22:49 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 11 months ago (2012-01-20 00:23:56 UTC) #2
James Cook
LGTM. Thanks for taking care of this.
8 years, 11 months ago (2012-01-20 05:50:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/9264025/1001
8 years, 11 months ago (2012-01-20 15:30:52 UTC) #4
commit-bot: I haz the power
Try job failure for 9264025-1001 (retry) (retry) (retry) on mac_rel for step "update". It's a ...
8 years, 11 months ago (2012-01-20 18:11:32 UTC) #5
commit-bot: I haz the power
8 years, 11 months ago (2012-01-20 22:14:51 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698