Only clear monomorphic ICs on GC after Context exit

Only clear monomorphic ICs on GC after Context exit

Committed: https://code.google.com/p/v8/source/detail?r=10431

[Jakob Kummerow, 2012-01-18 13:08:28]

Please take a look.

I know that this approach is just a crude approximation of optimal behavior, but
it's better than nothing for now.

[Vyacheslav Egorov (Chromium), 2012-01-18 14:09:21]

lgtm with comments addressed.

https://chromiumcodereview.appspot.com/9255014/diff/1/src/api.cc
File src/api.cc (right):

https://chromiumcodereview.appspot.com/9255014/diff/1/src/api.cc#newcode744
src/api.cc:744: isolate->set_context_exit_happened(true);
I think we should try to reuse existing ContextDisposedNotification counter
instead of introducing new one.

https://chromiumcodereview.appspot.com/9255014/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://chromiumcodereview.appspot.com/9255014/diff/1/src/mark-compact.cc#new...
src/mark-compact.cc:885: && (target->ic_state() == MEGAMORPHIC ||
Serializer::enabled() ||
store (Serializer::enabled() || heap->isolate()->some_flag()) into a field (e.g.
flush_monomorphic_ics) on the markcompactcollector to avoid two memory reads on
this path.

[Jakob Kummerow, 2012-01-18 15:02:40]

Thanks for the comments. Is the new patch set what you had in mind?

https://chromiumcodereview.appspot.com/9255014/diff/1/src/api.cc
File src/api.cc (right):

https://chromiumcodereview.appspot.com/9255014/diff/1/src/api.cc#newcode744
src/api.cc:744: isolate->set_context_exit_happened(true);
On 2012/01/18 14:09:21, Vyacheslav Egorov wrote:
> I think we should try to reuse existing ContextDisposedNotification counter
> instead of introducing new one.

Done.

https://chromiumcodereview.appspot.com/9255014/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://chromiumcodereview.appspot.com/9255014/diff/1/src/mark-compact.cc#new...
src/mark-compact.cc:885: && (target->ic_state() == MEGAMORPHIC ||
Serializer::enabled() ||
On 2012/01/18 14:09:21, Vyacheslav Egorov wrote:
> store (Serializer::enabled() || heap->isolate()->some_flag()) into a field
(e.g.
> flush_monomorphic_ics) on the markcompactcollector to avoid two memory reads
on
> this path.

Done.

[Vyacheslav Egorov (Chromium), 2012-01-18 15:16:28]

LGTM!