Issue 9254040: remove build_webkit_exes_from_webkit_gyp flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9254040: remove build_webkit_exes_from_webkit_gyp flag (Closed)

Created:
8 years, 11 months ago by Dirk Pranke

Modified:
8 years, 11 months ago

Reviewers:
tony

CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

remove build_webkit_exes_from_webkit_gyp flag R=tony@chromium.org BUG=105823 TEST=everything stays green Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118774

Patch Set 1 #

Patch Set 2 : remove more hacks #

Total comments: 2

Patch Set 3 : put back blob's dependency on webkit, fix indentation #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -86 lines)			Patch
M	build/common.gypi	View	1 2	1 chunk	+0 lines, -6 lines	0 comments	Download
M	content/content.gyp	View	1	1 chunk	+1 line, -5 lines	0 comments	Download
M	webkit/appcache/webkit_appcache.gypi	View	1	3 chunks	+2 lines, -16 lines	0 comments	Download
M	webkit/blob/webkit_blob.gypi	View	1 2	2 chunks	+1 line, -8 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.gypi	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	webkit/webkit.gyp	View	1 2	2 chunks	+14 lines, -51 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

Note that this probably shouldn't land until we've rolled to r105449 at least.

8 years, 11 months ago (2012-01-20 02:52:41 UTC) #1

tony

8 years, 11 months ago (2012-01-21 00:39:46 UTC) #2

LGTM.  Please use the commit queue or get a green run on the try bots.

http://codereview.chromium.org/9254040/diff/2001/webkit/webkit.gyp
File webkit/webkit.gyp (right):

http://codereview.chromium.org/9254040/diff/2001/webkit/webkit.gyp#newcode19
webkit/webkit.gyp:19:
'../third_party/WebKit/Source/WebKit/chromium/WebKitUnitTests.gyp:webkit_unit_tests'
Nit: indention

http://codereview.chromium.org/9254040/diff/2001/webkit/webkit.gyp#newcode26
webkit/webkit.gyp:26:
'../third_party/WebKit/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:DumpRenderTree'
Nit: indention

Expand Messages | Collapse Messages