Make sure to use an ObjectArray when writing to a socket

runtime/bin/socket_impl.dart

-// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
 class _SocketBase {
   // Bit flags used when communicating between the eventhandler and
   // dart code. The EVENT flags are used to indicate events of
   // interest when sending a message from dart code to the
   // eventhandler. When receiving a message from the eventhandler the
   // EVENT flags indicate the events that actually happened. The
@@ skipping 303 matching lines @@
       }
       if (offset < 0) {
         throw new IndexOutOfRangeException(offset);
       }
       if (bytes < 0) {
         throw new IndexOutOfRangeException(bytes);
       }
       if ((offset + bytes) > buffer.length) {
         throw new IndexOutOfRangeException(offset + bytes);
       }
-      var bytes_written = _writeList(buffer, offset, bytes);
+      ObjectArray outBuffer;
+      int outOffset = offset;
+      if (buffer is ObjectArray) {
+        outBuffer = buffer;
+      } else {
+        // When using the Dart C API access to ObjectArray by index is

[Mads Ager (google), 2012/01/19 08:38:25]

Please move the comment to the same place as in the other file so the pattern is
easier to recognize.

[Søren Gjesse, 2012/01/19 08:45:14]

Done.

+        // currently much faster. This function will make a *copy* of
+        // the supplied List to an ObjectArray if it isn't already.
+        outBuffer = new ObjectArray(bytes);
+        outOffset = 0;
+        int j = offset;
+        for (int i = 0; i < bytes; i++) {
+          outBuffer[i] = buffer[j];
+          j++;
+        }
+      }
+      var bytes_written = _writeList(outBuffer, outOffset, bytes);
       if (bytes_written < 0) {
         // If writing fails we return 0 as the number of bytes and
         // report the error on the error handler.
         bytes_written = 0;
         _reportError();
       }
       return bytes_written;
     }
     throw new
         SocketIOException("Error: writeList failed - invalid socket handle");
@@ skipping 119 matching lines @@
   bool _seenFirstOutEvent = false;
   bool _closedRead = false;
   bool _closedWrite = false;
   bool _pipe = false;
   Function _clientConnectHandler;
   Function _clientWriteHandler;
   SocketInputStream _inputStream;
   SocketOutputStream _outputStream;
 }