Add a startup check to create profile shortcuts for legacy Chrome profiles.

chrome/browser/profiles/profile_shortcut_manager_win.cc

Index: chrome/browser/profiles/profile_shortcut_manager_win.cc
===================================================================
--- chrome/browser/profiles/profile_shortcut_manager_win.cc	(revision 117854)
+++ chrome/browser/profiles/profile_shortcut_manager_win.cc	(working copy)
@@ -213,7 +213,7 @@
 ProfileShortcutManagerWin::~ProfileShortcutManagerWin() {
 }
 
-void ProfileShortcutManagerWin::OnProfileAdded(
+void ProfileShortcutManagerWin::AddProfileShortcut(

[sail, 2012/01/18 19:32:51]

do you need to check kProfileShortcutCreated here?

[SteveT, 2012/01/18 19:46:01]

This is a good question. I somewhat prefer keeping all the Prefs checking
outside of ProfileShortcutManagerWin and leave it in ProfileManager, where we
touch a lot of other prefs. I feel like this class doesn't need to get involved
in the decision making process, as that logic belongs in the actual Profiles
infrastructure. Adding it here would be extra safe, but also redundant and
couples it a bit more with the Profiles state.

Is that OK?

[sail, 2012/01/18 19:53:35]

I'm a bit confused. You added a new 'kProfileShortcutCreated' pref but you're
not using it anywhere. Were you planning to use it in this CL?

[SteveT, 2012/01/18 20:17:40]

Oh my gosh, I totally forgot to upload profile_manager.cc, which is the crux of
this whole thing. kProfileShortcutCreated is checked and set there.

     const FilePath& profile_path) {
   ProfileInfoCache& cache =
       g_browser_process->profile_manager()->GetProfileInfoCache();
@@ -286,6 +286,10 @@
   }
 }
 
+void ProfileShortcutManagerWin::OnProfileAdded(

[sail, 2012/01/18 19:32:51]

can this be removed?

[SteveT, 2012/01/18 19:46:01]

Unfortunately this comes from ProfileInfoCacheObserver, which declared
OnProfileAdded as abstract, so we have to give it an empty body here.

[sail, 2012/01/18 19:53:35]

Area any other observers using this? If not then can it be removed?

[SteveT, 2012/01/18 20:17:40]

Yes, BackgroundModeManager is also a ProfileInfoCacheObserver, so we can't
remove OnProfileAdded completely.

+    const FilePath& profile_path) {
+}
+
 void ProfileShortcutManagerWin::OnProfileWillBeRemoved(
     const FilePath& profile_path) {
   ProfileInfoCache& cache =